[Dash] Correctly set timeshift_buffer (live) #626
Conversation
|
I've been waiting for this for a long time. I can't wait to test it ! |
|
Looks good. |
|
That's what I read as well. timeShiftBufferDepth is only present with dynamic (live) so is a good identifier as well. We could also check profiles for is-off-live. But profiles can list multiple profiles. And I couldn't see a c++ function to search within a const chr. We would need to convert to std:string then find on that. Maybe something we can do in the future if we find live manifests not using type and not using timeshiftbuffer |
src/test/TestDASHTree.cpp
Outdated
| @@ -128,4 +134,4 @@ TEST_F(DASHTreeTest, CalculateCorrectSegmentNumbersFromSegmentTimeline) | |||
| EXPECT_EQ(segments.size(), 13); | |||
| EXPECT_EQ(segments[0]->range_end_, 487050); | |||
| EXPECT_EQ(segments[12]->range_end_, 487062); | |||
| } | |||
| } | |||
|
@phunkyfish conflict fixed. New line added.added a 2nd test. squashed into a single commit |
Fixes: d21spike/plugin.video.sling#22 (also needs PR: #564)
With the below MPD, currently IA will set the stream to VOD when it is actually LIVE
This is because "mediaPresentationDuration" comes after "type".
mediaPresentationDuration sets bStatic to true
So, currently it goes
The order or attributes should be irrelevant.
With this PR, VOD is default and it's ever only setting LIVE to true when either dynamic or timeShiftBufferDepth found
It doesn't unset LIVE.