Assorted fixes #29
Merged
Assorted fixes #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling echo on expanded results only serves to negate the advantage of using an array, as it will split any array element on whitespace. Signed-off-by: Yann Dirson <[email protected]> Cc: Simone Conti <[email protected]>
This is only used by this shell snippet. Signed-off-by: Yann Dirson <[email protected]> Cc: Simone Conti <[email protected]>
There's no apparent reason for such a restriction. We'll need to revisit anyway when XCP-ng supports other archs. Just passing through the --platform flag will likely be better. Signed-off-by: Yann Dirson <[email protected]> Cc: Simone Conti <[email protected]>
Example predates the introduction of -v as run.py argument. Signed-off-by: Yann Dirson <[email protected]>
We don't need any parsing beyond pattern matching, especially when given parsing is brittle. Signed-off-by: Yann Dirson <[email protected]>
Besides that egrep is deprecated, the command was intended to be run against /etc/groups, but acted on stdin. getent is a much cleaner way to do the check anyway. Signed-off-by: Yann Dirson <[email protected]> Cc: Simone Conti <[email protected]>
Signed-off-by: Yann Dirson <[email protected]> Cc: Simone Conti <[email protected]>
ydirson
force-pushed
the
assorted-fixes
branch
from
c609b4c
to
d198d4a
Compare
Merged
stormi
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.