Podman support #30
Merged
Podman support #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydirson
force-pushed
the
podman
branch
2 times, most recently
from
1853180
to
016050b
Compare
stormi
reviewed
Nov 13, 2023
stormi
reviewed
Nov 13, 2023
stormi
reviewed
Nov 13, 2023
Good point. Would indeed seem to advocate for looking for It would require identifying that a But that case already does not work today, this PR just does not address that particular issue (ie. we could handle this in a separate PR). |
It currently passes format checks only by abuse, and won't pass any more with following commits. Signed-off-by: Yann Dirson <[email protected]>
We're going to introduce podman support, this prepares the doc to make real changes easier to review. Signed-off-by: Yann Dirson <[email protected]>
podman does not interact with a daemon running as root, so unlike docker it will not be able to modify files owned by arbitrary users including root. To keep with current practices, we need to pass --userns=keep-id so it can write into the user's directories: the `builder` user inside the container is indeed equivalent to the user launching the container. All other users including root are mapped UIDs not existing on the host (typically 100000 and above), so any file created by such users in build trees in the container will (by design) have those (numeric-only) owners on the host if they remain after the build. Signed-off-by: Yann Dirson <[email protected]>
`podman-docker` installs a `docker` binary calling `podman`, we have to call it to discover how to properly handle it. Signed-off-by: Yann Dirson <[email protected]>
Signed-off-by: Yann Dirson <[email protected]>
stormi
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #29