Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove discovery events properly #1399

Open
pelageech opened this issue Aug 8, 2024 · 0 comments
Open

feat: remove discovery events properly #1399

pelageech opened this issue Aug 8, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@pelageech
Copy link

pelageech commented Aug 8, 2024

Feature Request

Describe the Feature Request
Hi! In #1390 I wanted to descibe the problem with infinite discovery events. They litter our traces, and I suppose they slow down our trace search.

In other to remove discovery events completely from traces you need to provide tracing details with such a bit mask:

trace.DetailsAll^trace.DriverRepeaterEvents^trace.DiscoveryEvents^trace.DriverBalancerEvents^trace.DriverConnEvents

Firstly, this is too complicated since I need 4 flags to remove 4 spans spawning infinitely.
Снимок экрана 2024-08-08 в 13 18 24
I would like to remove them in one xor.

Secondly, ^trace.DriverConnEvents leads to the loss of spans in other parts. I would like to remove (*conn).Invoke spans only for discovery events but to leave them in query events and so on.

Describe Preferred Solution
So, one flag to remove discovery events instead of four and splitting (*conn).Invoke traces into discovery and non-discovery.

Describe Alternatives

Related Code

Additional Context

If the feature request is approved, would you be willing to submit a PR?
No

@pelageech pelageech added the enhancement New feature or request label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant