Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

empty types are aliases now #1359

Merged
merged 1 commit into from
Jul 24, 2024
Merged

empty types are aliases now #1359

merged 1 commit into from
Jul 24, 2024

Conversation

rekby
Copy link
Member

@rekby rekby commented Jul 24, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

Copy link

summary

Base version: v3.75.3-0.20240719131448-bb1fee1e0085 (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.75.2.

@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.79%. Comparing base (bb1fee1) to head (a558e56).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1359      +/-   ##
==========================================
+ Coverage   42.53%   42.79%   +0.26%     
==========================================
  Files         335      335              
  Lines       34552    33787     -765     
==========================================
- Hits        14695    14460     -235     
+ Misses      19385    18852     -533     
- Partials      472      475       +3     
Flag Coverage Δ
go-1.20.x 44.86% <ø> (-0.05%) ⬇️
go-1.21.x 44.30% <ø> (-0.65%) ⬇️
go-1.22.x 41.95% <ø> (-0.55%) ⬇️
macOS 41.98% <ø> (-0.02%) ⬇️
ubuntu 41.98% <ø> (-0.06%) ⬇️
unit 42.79% <ø> (+0.26%) ⬆️
windows 44.79% <ø> (+2.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rekby rekby merged commit c12b35d into master Jul 24, 2024
43 checks passed
@rekby rekby deleted the fix-empty branch July 24, 2024 10:22
Copy link

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

Copy link

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table

Copy link

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over query-service with session pool:

Grafana Dashboard

SLO-native-query-with-pool

Copy link

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

Copy link

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-database-sql

Copy link

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over query-service:

Grafana Dashboard

SLO-native-query

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants