MNT: cleanup cibuildwheel configuration and move it to pyproject.toml
#4949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
commented
Jul 21, 2024
| @@ -35,16 +35,6 @@ jobs: | |||
| uses: pypa/[email protected] | |||
| with: | |||
| output-dir: dist | |||
| env: | |||
| CIBW_BUILD: "cp39-* cp310-* cp311-* cp312-*" | |||
| CIBW_SKIP: "*-musllinux_*" # numpy doesn't have wheels for musllinux so we can't build some quickly and without bloating | |||
There was a problem hiding this comment.
I didn't keep this comment because it's not true anymore, but I'm still skipping musllinux wheels
| CIBW_SKIP: "*-musllinux_*" # numpy doesn't have wheels for musllinux so we can't build some quickly and without bloating | ||
| CIBW_ARCHS_LINUX: "x86_64" | ||
| CIBW_ARCHS_MACOS: auto | ||
| MACOSX_DEPLOYMENT_TARGET: "10.9" # as of CIBW 2.9, this is the default value, pin it so it can't be bumped silently |
There was a problem hiding this comment.
I removed this option entirely because Python 3.13 will only support MacOS 10.13 and above, and cibuildwheel already does the right thing for us so it's not worth constraining it
See https:/pypa/cibuildwheel/blob/6c5cf878718641c3cbf21d69c670ff2e53a8263c/cibuildwheel/macos.py#L297-L308
neutrinoceros
changed the title
pyproject.toml
neutrinoceros
added
build
18 tasks
chrishavlin
approved these changes
Jul 22, 2024
|
I'll merge this now to help working on #4953 locally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This should help testing wheel building locally, and was also an opportunity to clean up our cibuildwheel configuration.