Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT: cleanup cibuildwheel configuration and move it to pyproject.toml #4949

Merged
merged 1 commit into from
Jul 25, 2024
Merged

MNT: cleanup cibuildwheel configuration and move it to pyproject.toml #4949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions .github/workflows/wheels.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,16 +35,6 @@ jobs:
uses: pypa/[email protected]
with:
output-dir: dist
env:
CIBW_BUILD: "cp39-* cp310-* cp311-* cp312-*"
CIBW_SKIP: "*-musllinux_*" # numpy doesn't have wheels for musllinux so we can't build some quickly and without bloating
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't keep this comment because it's not true anymore, but I'm still skipping musllinux wheels

CIBW_ARCHS_LINUX: "x86_64"
CIBW_ARCHS_MACOS: auto
MACOSX_DEPLOYMENT_TARGET: "10.9" # as of CIBW 2.9, this is the default value, pin it so it can't be bumped silently
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this option entirely because Python 3.13 will only support MacOS 10.13 and above, and cibuildwheel already does the right thing for us so it's not worth constraining it
See https:/pypa/cibuildwheel/blob/6c5cf878718641c3cbf21d69c670ff2e53a8263c/cibuildwheel/macos.py#L297-L308

CIBW_ARCHS_WINDOWS: auto64
CIBW_BUILD_VERBOSITY: 1
CIBW_TEST_EXTRAS: test
CIBW_TEST_COMMAND: pytest -c {project}/pyproject.toml --rootdir . --color=yes --pyargs yt

- uses: actions/upload-artifact@v4
with:
Expand Down
18 changes: 18 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,3 +492,21 @@ warn_unused_ignores = true
warn_unreachable = true
show_error_context = true
exclude = "(test_*|lodgeit)"

[tool.cibuildwheel]
build = "cp39-* cp310-* cp311-* cp312-*"
build-verbosity = 1
test-skip = "*-musllinux*"
test-extras = "test"
test-command = [
"pytest -c {project}/pyproject.toml --rootdir . --color=yes --pyargs yt -ra",
]

[tool.cibuildwheel.linux]
archs = "x86_64"

[tool.cibuildwheel.macos]
archs = "auto"

[tool.cibuildwheel.windows]
archs = "auto64"
Loading