Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are there nodejs files in zed #7054

Closed
1 task done
ethan-phu opened this issue Jan 30, 2024 · 2 comments
Closed
1 task done

Why are there nodejs files in zed #7054

ethan-phu opened this issue Jan 30, 2024 · 2 comments
Labels
defect [core label] workspace Feedback for workspace management, layout, interactions, etc

Comments

@ethan-phu
Copy link

ethan-phu commented Jan 30, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

I used clean my mac to check the space occupied by zed. I found that there is a node folder in the zed folder in the support file, which takes up about 200 megabytes. I want to know what is the main function of this? Can it be removed later?
image
image

Environment

image

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

No response

@ethan-phu ethan-phu added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels Jan 30, 2024
@SomeoneToIgnore
Copy link
Contributor

Zed installs various tools based on nodejs, e.g. formatters (prettier) and language servers (copilot, typescript, javascript, json, ...).
Zed only downloads things that are being used (e.g. a file is being opened that required a TS langserver) or enabled by default (e.g. formatter has auto setting that includes formatting with prettier), and the node itself (also on the first access, not unconditionally).

You can remove those directories, but Zed will either break (if it's running at that moment) and/or redownload them next time the related feature is used.

We do not have plans to abandon this approach since there's so much code written to support various frontend tools already, that rewriting those in Rust will take an eternity, so not sure what is actionable here, hence closing.

@karenetheridge
Copy link

This doesn't look good. https://old.reddit.com/r/programming/comments/1dxmroj/zed_editor_automatically_downloads_binaries_and/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect [core label] workspace Feedback for workspace management, layout, interactions, etc
Projects
None yet
Development

No branches or pull requests

4 participants