Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade nodejs so unneeded nodejs files aren't downloaded #7308

Closed
1 task done
koramangalacode opened this issue Feb 2, 2024 · 4 comments
Closed
1 task done

Upgrade nodejs so unneeded nodejs files aren't downloaded #7308

koramangalacode opened this issue Feb 2, 2024 · 4 comments
Labels
defect [core label]

Comments

@koramangalacode
Copy link

koramangalacode commented Feb 2, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

Unneeded nodejs files are being downloaded, wasting data for those stuck with metered internet
#6803
nodejs/node#46451

Environment

macOS

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

No response

@koramangalacode koramangalacode added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels Feb 2, 2024
@maxdeviant
Copy link
Member

Looking at the linked Node issue (nodejs/node#46451), it seems like those files are still present in the Node distributions?

I only saw mention of removing them from the Docker images, which Zed does not use.

@koramangalacode
Copy link
Author

koramangalacode commented Feb 5, 2024

I'm not sure how but those files end up on my mac but someone else has confirmed it happens to them too.

#7054

@maxdeviant
Copy link
Member

Zed installs the Node runtime when it is needed for certain language servers, and those files are distributed with Node, AFAICT.

@JosephTLyons JosephTLyons removed triage Maintainer needs to classify the issue admin read Pending admin review labels Feb 6, 2024
@maxdeviant
Copy link
Member

This is blocked on upstream changes in Node, so going to close it out as there's nothing for us to do at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect [core label]
Projects
None yet
Development

No branches or pull requests

3 participants