Skip to content
This repository has been archived by the owner on May 16, 2018. It is now read-only.

Implement Zend_Pdf::getJavascript() and Zend_Pdf::setJavascript() #374

Closed
adeelnawaz opened this issue Jun 6, 2014 · 2 comments
Closed

Comments

@adeelnawaz
Copy link
Contributor

The methods Zend_Pdf::getJavascript() and Zend_Pdf::setJavascript() have been declared without an implementation. These methods should be implemented to get or set PDF's embedded JavaScript.

@adeelnawaz adeelnawaz changed the title Implement Zend_Pdf::getJavascript() and Zend_Pdf::setJavascript() Implement Zend_Pdf::getJavascript() and Zend_Pdf::setJavascript() Jun 6, 2014
@adeelnawaz
Copy link
Contributor Author

I'm not sure how I can assign this issue to myself. I have already fixed it and I have a patch to submit. Please advise.

@froschdesign
Copy link
Member

I have already fixed it and I have a patch to submit.

We will not add any new features or functionality for ZF1.
Please send your proposal to zendframework/ZendPdf. Thanks!

adeelnawaz added a commit to adeelnawaz/zf1 that referenced this issue Jun 6, 2014
Changes:
- Implementation of `setJavaScript()` and `getJavaScript()` added for manipulating document-level JavaScript.
- Additionally, `resetJavaScript()` and `addJavaScript()` methods added.

See the docblocks for all four methods for the description of their operations.

zendframework#374 fixed.
froschdesign added a commit that referenced this issue Jun 26, 2014
Fixes #374 - Implement Zend_Pdf::getJavascript() and Zend_Pdf::setJavascript()
xopherdeep pushed a commit to xopherdeep/Zend-Framework-v1 that referenced this issue Jul 3, 2014
Changes:
- Implementation of `setJavaScript()` and `getJavaScript()` added for manipulating document-level JavaScript.
- Additionally, `resetJavaScript()` and `addJavaScript()` methods added.

See the docblocks for all four methods for the description of their operations.

zendframework#374 fixed.
xopherdeep pushed a commit to xopherdeep/Zend-Framework-v1 that referenced this issue Jul 3, 2014
Fixes zendframework#374 - Implement Zend_Pdf::getJavascript() and Zend_Pdf::setJavascript()
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants