Fixes #374 - Implement Zend_Pdf::getJavascript() and Zend_Pdf::setJavascript() #375
Conversation
Changes: - Implementation of `setJavaScript()` and `getJavaScript()` added for manipulating document-level JavaScript. - Additionally, `resetJavaScript()` and `addJavaScript()` methods added. See the docblocks for all four methods for the description of their operations. zendframework#374 fixed.
|
@adeelnawaz
|
|
@froschdesign I'll write the tests and submit signed CLA as soon as I get a chance. Can I submit CLA online? or is it accepted as a hard copy only? |
Unit tests include: - Zend_Pdf::getJavascript() - Zend_Pdf::setJavascript() - Zend_Pdf::resetJavascript() - Zend_Pdf::addJavascript() Added Zend_PdfTest test suite to AllTests.php
|
@froschdesign unit tests implemented and signed CLA has been emailed. |
|
@froschdesign could you please look into the failed build? It has failed due to someone else's test. The strange thing is that the build test for PHP 5.3 has failed. But it passes on my local machine when run on PHP 5.3. |
|
@akrabat |
|
@adeelnawaz |
| class Zend_PdfTest extends PHPUnit_Framework_TestCase | ||
| { | ||
|
|
||
| public function testGetJavasriptNull() |
There was a problem hiding this comment.
Typo: should be testGetJavaScript.
There was a problem hiding this comment.
I had an illusion that Zend_Pdf has methods like Javascript and not JavaScript. I must have mixed it up with another library. I'll fix that asap.
|
Is the JS run by Adobe Reader? |
|
JS is run by almost all PDF readers. Modern browsers support it too. |
|
I learn something every day :) @froschdesign, personally, I'm happy for this change to go in, if you are and we're happy that the Travis failure is nothing to do with it. |
|
@adeelnawaz Thanks! |
Fixes #374 - Implement Zend_Pdf::getJavascript() and Zend_Pdf::setJavascript()
froschdesign
changed the title
Fixes zendframework#374 - Implement Zend_Pdf::getJavascript() and Zend_Pdf::setJavascript()
Changes:
setJavaScript()andgetJavaScript()added for manipulating document-level JavaScript.resetJavaScript()andaddJavaScript()methods added.See the docblocks for all four methods for the description of their operations.
#374 fixed.