hal: tdk: cmakelist issue #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 10, 2024
afontaine-invn
force-pushed
the
main
branch
2 times, most recently
from
579dbbd
to
4753294
Compare
dkalowsk
approved these changes
Sep 18, 2024
CMakeLists.txt
Outdated
|
|
||
| zephyr_library() | ||
| if(CONFIG_USE_EMD_ICM42670P) |
There was a problem hiding this comment.
You could make these zephyr_include_directories_ifdef just to keep it shorter and neater similar to your line 28.
There was a problem hiding this comment.
Done. Thanks for the review !
afontaine-invn
force-pushed
the
main
branch
from
4753294
to
b4a561f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include tdk hal library only if selected
Fix twister test
Signed-off-by: Aurelie Fontaine [email protected]