Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

twister: integration_platforms stopped working as it should #32835

Closed
PerMac opened this issue Mar 3, 2021 · 0 comments · Fixed by #32843
Closed

twister: integration_platforms stopped working as it should #32835

PerMac opened this issue Mar 3, 2021 · 0 comments · Fixed by #32843
Assignees
@nashif
Labels
area: Tests Issues related to a particular existing or missing test area: Twister Twister bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug

Comments

@PerMac
Copy link
Member

PerMac commented Mar 3, 2021

Describe the bug
The PR #30009 allowed to adding platforms not from the default list to be tested in the CI. However, in the current master, this feature does not work.

To Reproduce
Steps to reproduce the behavior:

  1. modify the hello_word sample by adding: - nrf52840dk_nrf52840 into the integration_platforms
  2. checkout zephyr-v2.4.0-1548-ga7aff4fe41
  3. run ./scripts/sanitycheck -G -T samples/hello_world/ -v
  4. see that 2 platforms are tested (nrf only built)
  5. checkout zephyr-v2.5.0-681-gf1a27a8189e3
  6. run './scripts/twister-G -T samples/hello_world/ -v'
  7. See that nrf52840 was ignored

Expected behavior
Tests are performed on all the platforms on the integration_platforms list

Impact
I think it is high severity bug, as it can hinder real bugs in different tests which are no more run in the CI

Environment (please complete the following information):

  • OS: Ubuntu 18.04
  • Toolchain Zephyr SDK 0.12.2
  • Commit SHA or Version used: given in the "To Reproduce"
@PerMac PerMac added the bug The issue is a bug, or the PR is fixing a bug label Mar 3, 2021
@PerMac PerMac added area: Tests Issues related to a particular existing or missing test area: Twister Twister priority: high High impact/importance bug labels Mar 3, 2021
@nashif nashif mentioned this issue Mar 3, 2021
Merged
nashif added a commit to nashif/zephyr that referenced this issue Mar 3, 2021
@nashif
twister: fix integration_platforms selection
e24f3ea 
Logic for selecting non-default platforms listed in
integration_platforms did not work. Functionality is restored in this
change.

Fixes zephyrproject-rtos#32835

Signed-off-by: Anas Nashif <[email protected]>
nashif added a commit that referenced this issue Mar 11, 2021
@nashif
twister: fix integration_platforms selection
e618a59 
Logic for selecting non-default platforms listed in
integration_platforms did not work. Functionality is restored in this
change.

Fixes #32835

Signed-off-by: Anas Nashif <[email protected]>
@PerMac PerMac mentioned this issue Mar 11, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nashif nashif

Labels
area: Tests Issues related to a particular existing or missing test area: Twister Twister bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

twister: fix integration_platforms selection nashif/zephyr
2 participants
@nashif @PerMac