Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sanitycheck: test on integration platforms on top of default platforms #30009

Conversation

nashif
Copy link
Member

@nashif nashif commented Nov 13, 2020

When running sanitycheck without any platform filters (-p option), we
take the default platforms and run on those only. When the -G options is
used for integration testing, the platforms listed as integration
platforms are not being added on top of default platforms.

This change adds integration platforms to the list an treats
integration_platforms as a positive filter, so that
integration_platforms are always being considered.

Fixes #29829

@github-actions github-actions bot added the area: Sanitycheck Sanitycheck has been renamed to Twister label Nov 13, 2020
When running sanitycheck without any platform filters (-p option), we
take the default platforms and run on those only. When the -G options is
used for integration testing, the platforms listed as integration
platforms are not being added on top of default platforms.

This change adds integration platforms to the list an treats
integration_platforms as a positive filter, so that
integration_platforms are always being considered.

Fixes zephyrproject-rtos#29829

Signed-off-by: Anas Nashif <[email protected]>
@nashif nashif force-pushed the sanitycheck/integration_platform_allow branch from ae36320 to a7aff4f Compare November 16, 2020 15:31
Copy link
Member

@carlescufi carlescufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good to me. I haven't tested it though.

Copy link
Member

@PerMac PerMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch does what it says. I tried it with having hello_word yaml modified with extra non-default platform added to the integration_platforms list. When run with -G the extra platform was also tested.

@carlescufi carlescufi merged commit 87e3ec4 into zephyrproject-rtos:master Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Sanitycheck Sanitycheck has been renamed to Twister
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On-PR CI needs to build a subset of tests for a subset of platforms regardless of the scope of the PR changes
3 participants