Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling DHCP without NET_MGMT shouldn't be allowed #33137

Closed
pabigot opened this issue Mar 8, 2021 · 1 comment · Fixed by #33146
Closed

Enabling DHCP without NET_MGMT shouldn't be allowed #33137

pabigot opened this issue Mar 8, 2021 · 1 comment · Fixed by #33146
Assignees
@jukkar
Labels
area: Networking

Comments

@pabigot
Copy link
Collaborator

pabigot commented Mar 8, 2021

It may be that enabling DHCP without NET_MGMT shouldn't be allowed

Yes, that is the case. After looking the code, the DHCP needs to know about the network interface status in order to trigger a renew when the network interface comes back up. It looks like we are missing proper selects for net mgmt config option in subsys/net/ip/Kconfig.ipv4 for DHCPv4.

Originally posted by @jukkar in #33105 (comment)
@pabigot pabigot mentioned this issue Mar 8, 2021
Closed
@jukkar
Copy link
Member

jukkar commented Mar 8, 2021

I can take and fix this.

@jukkar jukkar self-assigned this Mar 8, 2021
jukkar added a commit to jukkar/zephyr that referenced this issue Mar 8, 2021
@jukkar
net: dhcpv4: The client needs info about network interfaces
586a763 
DHCPv4 client code needs to know information when network
interfaces are going down and up. So make sure that network
management config options are enabled in that case.

Fixes zephyrproject-rtos#33137

Signed-off-by: Jukka Rissanen <[email protected]>
@jukkar jukkar mentioned this issue Mar 8, 2021
Merged
jukkar added a commit that referenced this issue Mar 11, 2021
@jukkar
net: dhcpv4: The client needs info about network interfaces
b8d4d9b 
DHCPv4 client code needs to know information when network
interfaces are going down and up. So make sure that network
management config options are enabled in that case.

Fixes #33137

Signed-off-by: Jukka Rissanen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jukkar jukkar

Labels
area: Networking
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

net: dhcpv4: The client needs info about network interfaces jukkar/zephyr
2 participants
@pabigot @jukkar