net: dhcp: avoid build warnings when event mgmt disabled #33105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If CONFIG_NET_MGMT_EVENT is not enabled then net_mgmt_init_event_callback() is defined to a macro that ignores its arguments, causing the callback structure and the handler to be unused producing a build warning. Signed-off-by: Peter Bigot <[email protected]>
pabigot
force-pushed
the
nordic/20210307a
branch
from
1e2ab66
to
ea49d42
Compare
|
It may be that enabling DHCP without NET_MGMT shouldn't be allowed; in any case something's wrong here. Try |
Yes, that is the case. After looking the code, the DHCP needs to know about the network interface status in order to trigger a renew when the network interface comes back up. It looks like we are missing proper selects for net mgmt config option in |
|
Closing this, track issue in #33137. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If CONFIG_NET_MGMT_EVENT is not enabled then
net_mgmt_init_event_callback() is defined to a macro that ignores its
arguments, causing the callback structure and the handler to be unused
producing a build warning.