Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: gsm_modem: Compilation failed, likely related to logging changes #35329

Closed
ycsin opened this issue May 17, 2021 · 0 comments · Fixed by #35330
Closed

samples: gsm_modem: Compilation failed, likely related to logging changes #35329

ycsin opened this issue May 17, 2021 · 0 comments · Fixed by #35330
Assignees
Labels
area: Modem bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug

Comments

@ycsin
Copy link
Member

ycsin commented May 17, 2021

Describe the bug
On the latest zephyr master, after added CONFIG_GSM_MUX=y to the prj.conf of the samples/net/gsm_modem and build that with:

west build -t ram_report --pristine -b frdm_k22f -- -DDTC_OVERLAY_FILE="boards/frdm_uart2_dts.overlay"

will result in massive compilation error related to log/uart_mux/struct gsm_mux.

It worked on master v2.5ish @ commit 365145a. Likely related to logging changes according to @jukkar on Slack

To Reproduce
Build the gsm_modem sample with the command written above.

Expected behavior
The sample should compiles fine, but for now it results in very long compilation error related to log/uart_mux/struct gsm_mux.

Impact
Unable to progress with anything that requires CONFIG_GSM_MUX=y

Logs and console output
Similar to this: compile_log.txt

Environment (please complete the following information):

  • OS: Windows 10
  • Toolchain: gnuarmembi
  • Commit SHA or Version used: Latest master
@ycsin ycsin added the bug The issue is a bug, or the PR is fixing a bug label May 17, 2021
@jukkar jukkar self-assigned this May 17, 2021
@jukkar jukkar added area: Modem priority: medium Medium impact/importance bug labels May 17, 2021
jukkar added a commit to jukkar/zephyr that referenced this issue May 17, 2021
The logging macros use _Generic() atm and it started to complain
when we are trying to print pointer value of gsm_dlci and gsm_mux
structs. Cast the pointer value to (void *) to overcome this.

Fixes zephyrproject-rtos#35329

Signed-off-by: Jukka Rissanen <[email protected]>
nashif pushed a commit that referenced this issue May 17, 2021
The logging macros use _Generic() atm and it started to complain
when we are trying to print pointer value of gsm_dlci and gsm_mux
structs. Cast the pointer value to (void *) to overcome this.

Fixes #35329

Signed-off-by: Jukka Rissanen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Modem bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants