Fix GSM modem compilation when muxing is enabled #35330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logging macros use _Generic() atm and it started to complain when we are trying to print pointer value of gsm_dlci and gsm_mux structs. Cast the pointer value to (void *) to overcome this. Fixes zephyrproject-rtos#35329 Signed-off-by: Jukka Rissanen <[email protected]>
Add a compile test for GSM muxing so that we catch possible issues in the future. Signed-off-by: Jukka Rissanen <[email protected]>
jukkar
added
area: Modem
area: Networking
area: Samples
rlubos
approved these changes
May 17, 2021
mniestroj
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logging macros use _Generic() atm and it started to complain when we are trying to print pointer value of gsm_dlci and gsm_mux structs. Cast the pointer value to (void *) to overcome this.
Add also compilation test to GSM modem sample so that we can catch this issue earlier.
Fixes #35329