Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XTPRE divider always enabled on F1 and add bluepill DT clock support #34744

Merged
merged 2 commits into from
May 5, 2021

Conversation

fabiobaltieri
Copy link
Member

@fabiobaltieri fabiobaltieri commented Apr 30, 2021

Hi, this fixes an XTPRE definition bug from #34609 and adds support to the bluepill board (don't see in any other existing PR).

Tested on a stm32_min_dev_blue board with blinky, without the change the timing is off.

Fixes #34633

This is always defined since:

755d09e include/drivers/clock_control: stm32: Update for STM32F1
support

So the condition has currently no effect and causes the prescaler to
always be set to /2.

Signed-off-by: Fabio Baltieri <[email protected]>
Convert the stm32_min_dev boards to the new device tree based config
setup.

Signed-off-by: Fabio Baltieri <[email protected]>
Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Copy link
Collaborator

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erwango erwango requested a review from carlescufi May 5, 2021 06:43
@nashif nashif merged commit 0a56ced into zephyrproject-rtos:master May 5, 2021
@fabiobaltieri fabiobaltieri deleted the f1-clk branch May 5, 2021 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

STM32: Mass conversion of boards to dts based clock control configuration
5 participants