include/drivers/clock_control: stm32: Deprecate use of Kconfig #34761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwango
requested review from
carlescufi,
galak,
MaureenHelm and
nashif
as code owners
github-actions
bot
added
area: API
erwango
force-pushed
the
dev_stm32_dt_clocks_deprecate_kconfig
branch
from
d7f7336
to
f30991d
Compare
|
DNM untill #34633 is closed |
galak
approved these changes
May 3, 2021
erwango
force-pushed
the
dev_stm32_dt_clocks_deprecate_kconfig
branch
from
f30991d
to
6098e48
Compare
galak
approved these changes
May 3, 2021
erwango
force-pushed
the
dev_stm32_dt_clocks_deprecate_kconfig
branch
2 times, most recently
from
29ff0cc
to
5bb00f8
Compare
|
@erwango Are we good to remove the DNM? |
erwango
force-pushed
the
dev_stm32_dt_clocks_deprecate_kconfig
branch
from
5bb00f8
to
be07b57
Compare
Following introduction of dts based driver configuration (cf zephyrproject-rtos#34120, zephyrproject-rtos#32609 and zephyrproject-rtos#34701), deprecate Kconfig symbols by generating a warning when one of these symbols is used. Signed-off-by: Erwan Gouriou <[email protected]>
Symbol CLOCK_STM32_HSE_CLOCK will remain in use in context of stm32 clock_control configuration using device tree, cf commit a7989f6. In preparation for next change, separate it from the others symbols definition. Also make it non dependent from other Kconfig symbols. Signed-off-by: Erwan Gouriou <[email protected]>
Add new symbol CLOCK_CONTROL_STM32_HAS_DTS to exclude definition of other CLOCK_CONTROL_STM32_* symbols when dts based configuration is in use. CLOCK_CONTROL_STM32_HAS_DTS is defined based on availability of "clocks" property in rcc node. Signed-off-by: Erwan Gouriou <[email protected]>
Cortex-M4 stm32mp1 zephyr relies on chip Cortex-A for clock configuration. No change is then required for conversion to dts based clocks configuration, but we do need to exclude use of newly deprecated Kconfig symbols. Signed-off-by: Erwan Gouriou <[email protected]>
In prts of the code, we use rcc node "clocks" property to testify the use of device tree for clocks configuration. This doesn't work in case of stm32h7 m4 targets as for those, "upstream rcc" clock configuration, such as sysclk source selection, is done on m7 core and hence rcc node doesn't have a "clocks" property. To work around this, use alternate "d1cpre" property in case of stm32h7 targets. Signed-off-by: Erwan Gouriou <[email protected]>
These were missing but not visible since value was defaulted in Kconfig. With Kconfig deprecation this breaks compilation. Signed-off-by: Erwan Gouriou <[email protected]>
Fix definition condition for APB1 and APB2. These were not visible until now as defaulted in Kconfig. Signed-off-by: Erwan Gouriou <[email protected]>
Along with other clocks settings, enable LSE clock using device tree. Signed-off-by: Erwan Gouriou <[email protected]>
erwango
force-pushed
the
dev_stm32_dt_clocks_deprecate_kconfig
branch
from
8d6eb29
to
7489ffd
Compare
This board clock configuration was relying on default Kconfig value for APB2 value, and hence apb2 has not been converted to device tree. Explicit apb2 value in dts. Signed-off-by: Erwan Gouriou <[email protected]>
|
New CI Failures: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following introduction of dts based drier configuration (cf #34120,
#32609 and #34701), deprecate Kconfig symbols by generating a warning
when one of these symbols is used.
Requires prior merge of #34701