tests: arm_interrupt: remove redundant test case part #36225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area: Tests
hakehuang
approved these changes
Jun 15, 2021
stephanosio
requested changes
Jun 22, 2021
The test case part in test_arm_interrupt, which is triggering a SysTick IRQ (when SysTick is not used for system timer implementation), to catch a spurious interrupt is not really testing what it is designed for. The reason is that the z_arm_exc_spurious has be re-designed to be invoked only if the kernel is built without support for system clock, i.e. with CONFIG_SYS_CLOCK_EXISTS=n, but this configuration is not compatible with ZTESTs and is, therefore, never tested in this test, in any configuration. When the SysTick is not implemented in the HW, it is not possible to set the PendSTSET bit, so this is not possible to execute this part of the test case, anyways. What we have been catching as an error, here, is the ASSERT in the sys_clock_isr() weak implementation, but asserts are verified earlier in this test case, so this part is really redundant. Signed-off-by: Ioannis Glaropoulos <[email protected]>
ioannisg
force-pushed
the
tests_arch_arm_interrupt_remove_redundant_case
branch
from
92e3704
to
8cb443c
Compare
ioannisg
commented
Jun 23, 2021
stephanosio
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test case part in test_arm_interrupt, which is
triggering a SysTick IRQ (when SysTick is not used
for system timer implementation), to catch a spurious
interrupt is not really testing what it is designed
for. The reason is that the z_arm_exc_spurious has
be re-designed to be invoked only if the kernel is
built without support for system clock, i.e. with
CONFIG_SYS_CLOCK_EXISTS=n, but this configuration is
not compatible with ZTESTs and is, therefore, never
tested in this test, in any configuration. When the
SysTick is not implemented in the HW, it is not
possible to set the PendSTSET bit, so this is not
possible to execute this part of the test case, anyways.
What we have been catching as an error, here, is the
ASSERT in the sys_clock_isr() weak implementation, but
asserts are verified earlier in this test case, so this
part is really redundant.
Signed-off-by: Ioannis Glaropoulos [email protected]
Fixes #34917
Fixes #35656