-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards: actinius_*: fix board init priority #36906
boards: actinius_*: fix board init priority #36906
Conversation
0459825
to
9150198
Compare
This fixes an issue that surfaced with Zephyr v2.6.0, where the GPIO driver has not completed initialization when attempting to use it during POST_KERNEL with KERNEL_INIT_PRIORITY_DEFAULT. Signed-off-by: Alex Tsamakos <[email protected]>
9150198
to
9f1254a
Compare
I tested your change on nrf-sdk v1.6.0 which uses v2.6.0-rc1. I am still getting the same error. Shouldn't |
It is actually linked to both the SPM and app. I am suspecting that you say that the function is not called in the app because you don't see a message about it, is that correct? The at_client has logging turned off; if you add "CONFIG_LOG=y" in your prj.conf you should then see this:
|
Yes, you are correct, logging was turned off. Thank you for clarifying. This still leaves SPM image printing on boot:
This is is probably be due to |
Indeed, this is because the SPM project is overriding |
Does zephyr (or sdk-nrf) have support for conditional inclusion of board.c? I am not all that much familiar with the build system, but I can see there For this particular problem this is fine, as we can ignore the failed SIM selection in SPM, as long as it's correctly initialized in the app image which I tested and it is. |
SYS_INIT(board_actinius_icarus_init, POST_KERNEL, | ||
CONFIG_KERNEL_INIT_PRIORITY_DEFAULT); | ||
/* Needs to happen after GPIO driver init */ | ||
SYS_INIT(board_actinius_icarus_init, POST_KERNEL, 99); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest adding a new Kconfig to make this configurable instead of hardcoding the value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO this operation should not be made configurable as the dependency is that it runs after the GPIO driver init, similar to #33740. Would that be ok?
This fixes an issue that surfaced with Zephyr v2.6.0, where the GPIO driver has not completed initialization when attempting to use it during POST_KERNEL with KERNEL_INIT_PRIORITY_DEFAULT.
Signed-off-by: Alex Tsamakos [email protected]