Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards: actinius_*: fix board init priority #36906

Merged
merged 1 commit into from
Aug 2, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions boards/arm/actinius_icarus/board.c
Original file line number Diff line number Diff line change
Expand Up @@ -40,5 +40,5 @@ static int board_actinius_icarus_init(const struct device *dev)
return 0;
}

SYS_INIT(board_actinius_icarus_init, POST_KERNEL,
CONFIG_KERNEL_INIT_PRIORITY_DEFAULT);
/* Needs to happen after GPIO driver init */
SYS_INIT(board_actinius_icarus_init, POST_KERNEL, 99);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest adding a new Kconfig to make this configurable instead of hardcoding the value

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this operation should not be made configurable as the dependency is that it runs after the GPIO driver init, similar to #33740. Would that be ok?

4 changes: 2 additions & 2 deletions boards/arm/actinius_icarus_bee/board.c
Original file line number Diff line number Diff line change
Expand Up @@ -40,5 +40,5 @@ static int board_actinius_icarus_bee_init(const struct device *dev)
return 0;
}

SYS_INIT(board_actinius_icarus_bee_init, POST_KERNEL,
CONFIG_KERNEL_INIT_PRIORITY_DEFAULT);
/* Needs to happen after GPIO driver init */
SYS_INIT(board_actinius_icarus_bee_init, POST_KERNEL, 99);
4 changes: 2 additions & 2 deletions boards/arm/actinius_icarus_som/board.c
Original file line number Diff line number Diff line change
Expand Up @@ -40,5 +40,5 @@ static int board_actinius_icarus_som_init(const struct device *dev)
return 0;
}

SYS_INIT(board_actinius_icarus_som_init, POST_KERNEL,
CONFIG_KERNEL_INIT_PRIORITY_DEFAULT);
/* Needs to happen after GPIO driver init */
SYS_INIT(board_actinius_icarus_som_init, POST_KERNEL, 99);