Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] @prizm-ui/components - PrizmPanelComponent extra border radius #1767

Closed
1 of 9 tasks
AleksandrSibiakov opened this issue Jun 4, 2024 · 1 comment
Closed
1 of 9 tasks

[BUG] @prizm-ui/components - PrizmPanelComponent extra border radius #1767

AleksandrSibiakov opened this issue Jun 4, 2024 · 1 comment
Assignees
@ickisIckis
Labels
source:idp issue from IDP state:ready ready for release (pass tested) type:bug Something isn't working
Milestone
4.3.2

Comments

@AleksandrSibiakov
Copy link
Contributor

Библиотека

Выберите нужное отметив галочку [x]

  • @prizm-ui/core
  • @prizm-ui/components
  • @prizm-ui/install
  • @prizm-ui/icons
  • @prizm-ui/flag-icons
  • @prizm-ui/theme
  • @prizm-ui/charts
  • @prizm-ui/ast
  • @prizm-ui/nx-plugin

Компонент

PrizmPanelComponent

Скрин / Видео проблемы

image

Шаги воспроизведения:

  1. Зайти по адресу prizm

Т.к. панель имеет только бордер снизу, нет необходимости задавать радиус (по умолчанию).
Дизайн спек

P.S. Может, предусмотреть также использование Panel в футере, т.е. возможность "перекинуть" бордер на верх.
@alexhawkins94 alexhawkins94 added the type:bug Something isn't working label Jun 5, 2024
@imonogarov imonogarov added this to the 4.3.2 milestone Jun 7, 2024
@imonogarov
Copy link
Collaborator

@AleksandrSibiakov по поводу P.S. желательно завести отдельную задачу

ickisIckis pushed a commit that referenced this issue Jun 7, 2024
fix(components/panel): set default border radius as 0px to panel #1767
807ff21
@ickisIckis ickisIckis mentioned this issue Jun 7, 2024
Merged
11 tasks
ickisIckis pushed a commit that referenced this issue Jun 7, 2024
fix(components/panel): set default border radius as 0px to panel #1767
eaf0b6b
@ickisIckis ickisIckis mentioned this issue Jun 7, 2024
Merged
11 tasks
@ickisIckis ickisIckis added the state:ready ready for release (pass tested) label Jun 7, 2024
ickisIckis pushed a commit that referenced this issue Jun 10, 2024
fix(components/panel): set default border radius as 0px to panel #1767
f77fc41
ickisIckis added a commit that referenced this issue Jun 13, 2024
@ickisIckis
Merge pull request #1790 from zyfra/fix/panel-border-radius_v3
f295a16 
fix(components/panel): set default border radius as 0px to panel #1767
@ickisIckis ickisIckis mentioned this issue Jun 13, 2024
Merged
62 tasks
ZurabDev added a commit that referenced this issue Jun 13, 2024
@ZurabDev
Merge pull request #1791 from zyfra/fix/panel-border-radius
15ddf44 
fix(components/panel): set default border radius as 0px to panel #1767
@ZurabDev ZurabDev mentioned this issue Jun 13, 2024
Merged
44 tasks
@bumalai bumalai added the source:idp issue from IDP label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ickisIckis ickisIckis

Labels
source:idp issue from IDP state:ready ready for release (pass tested) type:bug Something isn't working
Projects
None yet
Milestone
4.3.2
Development

No branches or pull requests
5 participants
@AleksandrSibiakov @ickisIckis @alexhawkins94 @bumalai @imonogarov