Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components/panel): set default border radius as 0px to panel #1767 #1791

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

ickisIckis
Copy link
Collaborator

@ickisIckis ickisIckis commented Jun 7, 2024

fix(components/panel): set default border radius as 0px to panel #1767

Библиотека

  • @prizm-ui/components
  • @prizm-ui/install
  • @prizm-ui/icons
  • @prizm-ui/theme

Компонент

Panle

Задача

#1767

Изменения

  • Имеются BREAKING CHANGES
  • Изменения документации
  • Добавление фичи
  • Исправление бага

Checklist:

  • После фичи обновил документацию
  • Сделал код чище чем был до этого
  • Тесты и линтер на рабочей машине успешно выполнились

Следует обратить внимание на ревью

Panel, встроенная в разные компоненты

Release Notes

исправили border radius у панели согласно макетам.

Copy link

github-actions bot commented Jun 7, 2024

Visit the preview URL for this PR (updated for commit f77fc41):

https://prizm-v4--pr1791-fix-panel-border-rad-21too7m1.web.app

(expires Sat, 15 Jun 2024 09:38:08 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 7c62ed8dbabf5e2d6b2084ca9e107cc206d30dbd

ZurabDev
ZurabDev previously approved these changes Jun 10, 2024
Copy link
Contributor

@ZurabDev ZurabDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZurabDev
Copy link
Contributor

Файл package-lock зачем обновили?

@ZurabDev ZurabDev dismissed their stale review June 10, 2024 05:54

package-lock

@ickisIckis
Copy link
Collaborator Author

Файл package-lock зачем обновили?

исправлено, спасибо

Copy link
Contributor

@ZurabDev ZurabDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZurabDev ZurabDev merged commit 15ddf44 into main Jun 13, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants