Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

headingPitchRollToQuaternion should be calculated counter clock wise #5666

Open
ggetz opened this issue Jul 21, 2017 · 4 comments
Open

headingPitchRollToQuaternion should be calculated counter clock wise #5666

ggetz opened this issue Jul 21, 2017 · 4 comments

Comments

@ggetz
Copy link
Contributor

ggetz commented Jul 21, 2017

As per this discussion on the forum: https://groups.google.com/forum/#!topic/cesium-dev/2-Fn_8yeurY

@kaktus40
Copy link
Contributor

kaktus40 commented Sep 5, 2017

Hello, I make a pull request but I think that this PR should be completed with an articles that explains how to change.

@ggetz
Copy link
Contributor Author

ggetz commented Sep 6, 2017

@kaktus40 We'll update the forum page as soon as the PR is in and the issue is closed! Thanks!

@pjcozzi
Copy link
Contributor

pjcozzi commented Sep 6, 2017

@hpinkos
Copy link
Contributor

hpinkos commented Oct 2, 2017

This was initially added in #5848 but we decided to revert it before the release because it was too big of a breaking change. See the discussion in #5868.
Changes are currently parked in the ccw-hpr branch

How do we want to move forward with this? Is this a change we ultimately want to make or should this be a "won't fix"?

If clockwise is what the FAA suggests, maybe that's the standard we should stick with. It doesn't seem like this is standardized across the board, so the only benefit I see for making the switch to CCW would be to be consistent with Cesium's other rotations (like setting a rotation for a rectangle) or to be consistent with other AGI software (but I'm not sure how much of a priority that is).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants