Revert heading, pitch, roll changes #5872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good @bagnell, thanks! |
|
@kaktus40 sorry, but we decided to revert the heading/pitch/roll counter clockwise changes you made. It was hard to justify making such a big breaking change that would affect the vast majority of our user base. See the discussion in #5868. We may decide to make this change eventually, but we need to discuss it more so we understand the benefit of using CCW compared to the cost of forcing everyone to switch. We'll continue discussion in #5666 |
|
It's OK for me, I just hope that the community make a choice after thinking about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #5848 to fix #5868.
I'll add the changes to another branch when this is merged.