Add readonly support to input-date-picker & input-time-picker

[joeyHarig]

Description

Add read-only support to the input date and time pickers.

Acceptance Criteria

• A new readOnly prop is added
• When true, it should set readonly on the input to true and prevent the popover support components from being displayed.

Which Component

• calcite-input-date-picker
• calcite-input-time-picker

Example Use Case

Readonly: When the date/time has already been set and can not be changed.

Additional info

https:/Esri/calcite-components/blob/master/src/components/input/input.tsx#L215-L220
#2734

[driskull]

@paulcpederson @eriklharper @macandcheese We don't have readonly on calcite-input so we would need to add that first, correct? Is there a reason we don't have it currently?

[paulcpederson]

No, we should probably have readonly for inputs to maintain API parity with native HTML.

[macandcheese]

Yeah agree.. right now you can add readonly and the styles will correctly apply, and the attribute will render on the child input element... however it’s not defined as a custom prop - it’s just getting spread if present - so it’s not getting documented.

Should add that so it’s on the calcite input and to the point of the issue probably anything that wraps one like a date, or time input.

[eriklharper]

I'm in favor of removing spread attributes as a general principle. Best to always explicitly define the attributes being used and supported.

[driskull]

I'm in favor of removing spread attributes as a general principle. Best to always explicitly define the attributes being used and supported.

Yeah, we shouldn't be passing everything into the internals of the component.

[jcfranco]

The disabled prop support was handled by #2655, so I'll repurpose this issue to add read-only support to the input date/time pickers. cc @benelan

[jcfranco]

@benelan can we squeeze this one for this release?

[benelan]

@benelan can we squeeze this one for this release?

Sure, triaged!

[jcfranco]

@Elijbet Can you look at this one for this release?

[Elijbet]

@Elijbet Can you look at this one for this release?

Sure thing.

[github-actions]

Installed and assigned for verification.

[geospatialem]

Verified read-only attribute in beta.86 for input-time-picker and input-date-picker.