Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: calcite-input-time-picker disabled not being applied correclty #3225

Closed
joeyHarig opened this issue Oct 13, 2021 · 3 comments
Closed

Bug: calcite-input-time-picker disabled not being applied correclty #3225

joeyHarig opened this issue Oct 13, 2021 · 3 comments
Assignees
@benelan
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug.
Milestone
Sprint 02/28 - 03/11

Comments

@joeyHarig
Copy link
Contributor

Actual Behavior

When disabled is set on calcite-input-time-picker the component still functions as if it were not disabled. The time-picker popover still opens and the controls still work.

Expected Behavior

The calcite-input-time-picker should meet the following criteria when set to disabled.

  • The cursor should be the default cursor, not pointer or text (just like calcite-input when it is disabled)
  • The input should not be able to receive focus
  • The date-picker popover should not open when the input is clicked

Reproduction Steps and Sample

Sample: https://codepen.io/joeyHarig/pen/MWvwqJz?editors=1011

Notice how the enabled and disabled calcite-input-time-picker components behave very similarly.

Relevant Info

Version: @esri/calcite-components@ v1.0.0-beta.67

I noticed there is an epic for disabled states. This issue and issue #1947 could be added to that epic.
@joeyHarig joeyHarig added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Oct 13, 2021
@jcfranco jcfranco self-assigned this Oct 20, 2021
@jcfranco jcfranco removed the needs triage Planning workflow - pending design/dev review. label Oct 20, 2021
@jcfranco jcfranco added this to the Sprint 10/25 - 11/5 milestone Oct 20, 2021
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Dec 28, 2021
@jcfranco jcfranco mentioned this issue Dec 31, 2021
Closed
3 tasks
@jcfranco
Copy link
Member

Fixed via #2655.

@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Mar 11, 2022
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned benelan and unassigned jcfranco Mar 11, 2022
@benelan
Copy link
Member

benelan commented Mar 16, 2022

verified on beta.79

@benelan benelan closed this as completed Mar 16, 2022
@benelan benelan added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benelan benelan

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug.
Projects
None yet
Milestone
Sprint 02/28 - 03/11
Development

No branches or pull requests
3 participants
@jcfranco @benelan @joeyHarig