3039: Floating Social Media buttons on posts use wrong URL and title

[benlk]

Using the freshenergy theme, but not the largo theme, the floating social buttons display an incorrect post title and post URL. On an example post https://freshenergy.test/xcel-energys-next-steps-for-electric-vehicles/

Tweet: Donate Blurb https://freshenergy.test/donate-blurb/ via @freshenergy

Facebook: https://www.facebook.com/sharer/sharer.php?u=https%3A%2F%2Ffreshenergy.test%2Fdonate-blurb%2F

Email:

• title: Donate Blurb
• Body: Xcel Energy recently unveiled its vision for ‘what’s next’ with electric vehicles, which aims to speed the transition to electric transportation. The utility’s goal is to develop new services, pilot them, and then roll out the most successful ideas to customers on a broader scale. Fresh Energy is excited about the Minnesota electric vehicle plan’s […]https://freshenergy.test/donate-blurb/

Note that the email excerpt matches the post, but the title and blurb do not.

[benlk]

Largo's largo_post_social_links() function outputs the email link thusly: https:/INN/largo/blob/v0.6.1/inc/post-social.php#L90-L98

		if ( isset( $utilities['email'] ) && '1' === $utilities['email'] ) {
			$output .= sprintf(
				'<span data-service="email" class="email share-button"><a href="mailto:?subject=%2$s&body=%3$s%0D%0A%4$s" target="_blank"><i class="icon-mail"></i> <span class="hidden-phone">%1$s</span></a></span>',
				esc_attr( __( 'Email', 'largo' ) ),
				rawurlencode( html_entity_decode( get_the_title(), ENT_QUOTES, "UTF-8" ) ), // subject
				rawurlencode( html_entity_decode( strip_tags( get_the_excerpt() ), ENT_QUOTES, "UTF-8" ) ), // description
				rawurlencode( html_entity_decode( get_the_permalink() ) ) // url
			);
		}

The title, link, and excerpt should all be drawing from the same post, being the global $post, though that is not specified as an argument on these functions. If this were a problem with Largo, then changing the theme shouldn't affect the post chosen. Something in the theme is perhaps changing $post?

largo_post_social_links contains a number of filters, but none of them appear to be implemented in the freshenergy theme.

[benlk]

Yep, it's this bit in the footer:

umbrella-freshenergy/wp-content/themes/freshenergy/footer.php

Lines 18 to 27 in 5b54125

	<div class="widget span6">
	<h3><span>Make a Donation</span></h3>
	<?php
	$id=19314; // "Donate Blurb"
	$post = get_post($id);
	$content = apply_filters('the_content', $post->post_content);
	echo $content;
	?>
	</div>

[benlk]

cc3d8af solves this problem by fixing this ID problem, but there's the broader issue within Largo that the post social buttons aren't coupled to the requested post, but to $post. Changes to this function in Largo would require a different way of getting at the queried object. I'll open a ticket in Largo for that fix.

[benlk]

#22 fixes this problem in Fresh Energy's production environment by changing some variable names, which means that this theme is no longer triggering WPBuddy/largo#1634. However, we do need to fix WPBuddy/largo#1634 in Largo in the near future.