Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If $post at wp_footer doesn't match the queried object, the floating post social links will be thrown off. #1634

Open
2 tasks
benlk opened this issue Feb 14, 2019 · 0 comments
Labels
priority: normal Must be completed before release of this version of plugin. type: bug

Comments

@benlk
Copy link
Collaborator

benlk commented Feb 14, 2019

Discovered in INN/umbrella-freshenergy#21, where the fix was to make sure that the child theme's code didn't squash the global $post. However, we can't assume that plugins or widgets won't interfere with that.

SO:

  • write a test that
    1. Uses a post factory to create a post a
    2. Uses a post factory to create a post b
    3. Navigates to a
    4. Sets global $post to b
    5. Expects that the output of largo_post_social_links() is for a, not b
  • make point 5 above true, by drawing from the queried object rather than global $post.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: normal Must be completed before release of this version of plugin. type: bug
Projects
None yet
Development

No branches or pull requests

1 participant