Various Floating Social Buttons improvements #1635
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
largo_post_social_links
now respects the blog character set option. issue #1283.@grayLighter
to@gray
, which is from#dddddd
to#7D8185
against a#ffffff
background. This is actually a little bit short of the required contrast ratio; this change bumps it from1.36
to3.92
, but it should be at least4.5
. The next step on our color scheme is@grayDark
, #484848, at9.15
contrast ratio.a
coloration rules already present in the cascadeThis image shows the z-index change, meaning that floating social buttons float over wide images and full-width images, but are now clickable:
The above image also shows the old contrast levels.
Here's some samples of the new contrast level:
Questions
@tylermachado, should we go all the way to
4.5
contrast ratio? If so, should this be through adjusting@gray
(would require a review of the use of that color all across the theme) or should we define a new color?Why
Because I was examining this section of code for INN/umbrella-freshenergy#21 anyways, while discovering #1634
Change the button color to make them meet the WCAG AA standards for contrast.