Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate some routes #1199

Merged
merged 4 commits into from
Oct 24, 2017
Merged

Deprecate some routes #1199

merged 4 commits into from
Oct 24, 2017

Conversation

Martii
Copy link
Member

@Martii Martii commented Oct 24, 2017 •
edited
Loading

  • Normalize on /login... keep register to ourselves in the code... we already do this a lot... think index.js vs main.
  • Removed one dead route... why would we want to do /github to /... means to me that it's dead... just return a default 404.
  • Fixed one doc send with status 302 to redirect instead... default is 302 ... would use a 307 but that's only HTTP/1.1 and would definitely rule out any older browser although may be reconsidered at a later date
  • Some white space treatment
  • EDIT: Undeprecated a route... will address pluralization later. Leaving 302 in on purpose even though it's the default.

Applies to #1198 #135 and post #1174

@Martii
Deprecate some routes
7793beb 
* Normalize on `/login`... keep `register` to ourselves in the code... we already do this a lot... think `index.js` vs `main`.
* Removed one dead route... why would we want to do `/github` to `/`... means to me that it's dead... just return a default 404.
* Fixed one doc send with status 302 to redirect instead... default is 302 ... would use a 307 but that's only HTTP/1.1 and would definitely rule out any older browser although may be reconsidered at a later date
* Some white space treatment

Applies to OpenUserJS#1198 OpenUserJS#135 and post OpenUserJS#1174
@Martii Martii added bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. PR READY This is used to indicate that a pull request (PR) is ready for evaluation. UI Pertains inclusively to the User Interface. labels Oct 24, 2017
@Martii Martii added the security Usually relates to something critical. label Oct 24, 2017
@Martii
Revert last commit
09987af 
* Will exist for hook but root of it won't

Applies to OpenUserJS#135
@Martii Martii removed security Usually relates to something critical. PR READY This is used to indicate that a pull request (PR) is ready for evaluation. labels Oct 24, 2017
@Martii Martii merged commit 5c85bfa into OpenUserJS:master Oct 24, 2017
@Martii Martii deleted the Issue-1198tryLogin branch October 24, 2017 17:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. UI Pertains inclusively to the User Interface.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Martii