Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXUP/FEATURE/PIC] PIC API and MSI/MSI-X example #9428

Merged
merged 5 commits into from
Sep 19, 2024

Conversation

GuEe-GUI
Copy link
Contributor

@GuEe-GUI GuEe-GUI commented Sep 12, 2024

拉取/合并请求描述:(PR description)

[
Fixup:

  1. pirq reinit fail
  2. Set interrupt status when do traps
  3. pirq's child handler should lock less
  4. Fix some code style and init for V2M, ITS.

Feature:

  1. Support PIC cancel (only in debug)
  2. Add ARM GICv2/v3 V2M, ITS support.

Test:

  • qemu-virt64-aarch64
  • rockchip/rk3568

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

don't reinit pirq's list if cascade

Signed-off-by: GuEe-GUI <[email protected]>
When call the child handler, the PIC ops needn't
lock again.
Critical zone protection by PIC implementers.

Signed-off-by: GuEe-GUI <[email protected]>
PIC may free because some wrongs in debug.
We should remove in PIC list or there are
some undefined behavior will happen.

Signed-off-by: GuEe-GUI <[email protected]>
@GuEe-GUI GuEe-GUI changed the title Fixup pic [FIXUP/FEATURE/PIC] PIC API and MSI/MSI-X example Sep 12, 2024
@GuEe-GUI GuEe-GUI marked this pull request as draft September 12, 2024 05:41
@GuEe-GUI GuEe-GUI marked this pull request as ready for review September 12, 2024 05:45
@polarvid polarvid added the Status: waiting for test Waiting test for this PR. label Sep 14, 2024
Fix some code style and init for V2M, ITS.

V2M is the PCI MSI/MSI-X for GICv2.
ITS is the PCI MSI/MSI-X for GICv3/v4.

Signed-off-by: GuEe-GUI <[email protected]>
@Rbb666 Rbb666 merged commit 3d503e9 into RT-Thread:master Sep 19, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants