Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rules shouldn't rely on this #356

Open
4 tasks
SimenB opened this issue Oct 8, 2016 · 2 comments
Open
4 tasks

Rules shouldn't rely on this #356

SimenB opened this issue Oct 8, 2016 · 2 comments
Assignees
Milestone

Comments

@SimenB
Copy link
Owner

SimenB commented Oct 8, 2016

They should receive what they need as arguments, and return/invoke a callback with a result.

@SimenB
Copy link
Owner Author

SimenB commented Feb 26, 2017

@wojciechczerniak Getting back to this, finally.

What do you think about calling each rule with the full source instead of a single line at a time? It means every rule have to handle disable-comments (or we can strip them out before hand), but it makes it easier to reason about the state of the rule itself.

Still not sure what the best API is here.

@SimenB
Copy link
Owner Author

SimenB commented Feb 26, 2017

I'd like to release an alpha of v2 after this is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant