Drop separate err and warnings on cache #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
force-pushed
the
join-errs-warns
branch
from
b329507
to
5a67daa
Compare
|
One of the tests seems to recurse infinitely, haven't been able to figure out why. EDIT: It recursed becuase reporter called done. Done now calls the reporter, so this should be s start for #358 as well |
SimenB
force-pushed
the
join-errs-warns
branch
from
5a67daa
to
1711150
Compare
|
There's a |
SimenB
commented
Oct 8, 2016
| app.cache.rule = 'universal' | ||
| var msg = 'universal disallowed' | ||
| var expectedOutput = '\u001b[4mtestReporter\u001b[24m\n1:0 \u001b[90muniversal\u001b[39m \u001b[33mwarning\u001b[39m universal disallowed' |
There was a problem hiding this comment.
should just use chalk.stripColor, but whatever. Can fix when we refactor tests
There was a problem hiding this comment.
Yup, I expect tests to change a lot
SimenB
force-pushed
the
join-errs-warns
branch
from
1711150
to
b36ae4e
Compare
wojciechczerniak
approved these changes
Oct 8, 2016
|
@wojciechczerniak Good point! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #357
Also a start for #356
It's mostly a subset of #274, so it's probably a bit rough around the edges
/cc @wojciechczerniak