Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple reporter from this #358

Closed
SimenB opened this issue Oct 8, 2016 · 1 comment
Closed

Decouple reporter from this #358

SimenB opened this issue Oct 8, 2016 · 1 comment
Assignees
@SimenB
Labels
help wanted
Milestone
2.0.0

Comments

@SimenB
Copy link
Owner

SimenB commented Oct 8, 2016

Reporters should get a huge array of stuff to create a report from, and do whatever they want. Not mutate this.cache.messages, not call this.done etc.

Related to #356
@SimenB SimenB added this to the 2.0.0 milestone Oct 8, 2016
@wojciechczerniak wojciechczerniak mentioned this issue Oct 8, 2016
Open
This was referenced Oct 8, 2016
Open
Merged
@SimenB
Copy link
Owner Author

SimenB commented Oct 8, 2016

I'll do this after #363 is merged

@SimenB SimenB self-assigned this Oct 8, 2016
SimenB added a commit that referenced this issue Oct 8, 2016
@SimenB
[WIP] Don't use this in reporter
30ba3ff 
Fixes #358
SimenB added a commit that referenced this issue Oct 8, 2016
@SimenB
[WIP] Don't use this in reporter
6ed2bc1 
Fixes #358
SimenB added a commit that referenced this issue Oct 8, 2016
@SimenB
[WIP] Don't use this in reporter
e210d63 
Fixes #358
SimenB added a commit that referenced this issue Oct 8, 2016
@SimenB
[WIP] Don't use this in reporter
b516b03 
Fixes #358
SimenB added a commit that referenced this issue Oct 8, 2016
@SimenB
[WIP] Don't use this in reporter
7519738 
Fixes #358
SimenB added a commit that referenced this issue Oct 8, 2016
@SimenB
[WIP] Don't use this in reporter
7db4d19 
Fixes #358
SimenB added a commit that referenced this issue Oct 8, 2016
@SimenB
[WIP] Don't use this in reporter
9c42186 
Fixes #358
SimenB added a commit that referenced this issue Oct 8, 2016
@SimenB
Don't rely on this in reporter
0959c51 
Fixes #358
SimenB added a commit that referenced this issue Oct 8, 2016
@SimenB
Don't rely on this in reporter
e8a8c08 
Fixes #358
SimenB added a commit that referenced this issue Oct 8, 2016
@SimenB
Don't rely on this in reporter
e1c02b2 
Fixes #358
SimenB added a commit that referenced this issue Oct 8, 2016
@SimenB
Don't rely on this in reporter
a94b7d7 
Fixes #358
@SimenB SimenB added the review label Oct 9, 2016
SimenB added a commit that referenced this issue Oct 9, 2016
@SimenB
Don't rely on this in reporter
0daa8eb 
Fixes #358
@SimenB SimenB closed this as completed Oct 9, 2016
@SimenB SimenB removed the review label Oct 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimenB SimenB

Labels
help wanted
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@SimenB