Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve a couple of Github Action CI annoyances: #4413

Merged
merged 4 commits into from
Feb 15, 2023

Commits on Feb 6, 2023

  1. Resolve a couple of Github Action CI annoyances:

    * Set "fail-fast: false" so that multiple jobs in one workflow can
      finish independently. By default, if one job fails, other running jobs
      will be aborted, even if the other jobs are working fine and are
      almost done. This leads to wasted time and resources if the failure
      is, for example, OS specific, or due to a flaky unit test, and the
      failed job needs to be re-run, because all the jobs end up re-running.
    * Put conditions back into the windows.yml job (manual, and for
      a specific branch name and that job). This prevents Github Actions
      from sending "No jobs were run" failure emails on every commit.
    ximinez committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    bb675d0 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2023

  1. Merge remote-tracking branch 'upstream/develop' into action-annoyances

    * upstream/develop:
      Update dependency: grpc (XRPLF#4407)
      Introduce min/max observers for Number
      Optimize uint128_t division by 10 within Number.cpp
      Replace Number division algorithm
      Include rounding mode in XRPAmount to STAmount conversion.
      Remove undefined behavior * Taking the negative of a signed negative is UB, but   taking the negative of an unsigned is not.
      Silence warnings
      Introduce rounding modes for Number:
      Use Number for IOUAmount and STAmount arithmetic
      Add tests
      Add implicit conversion from STAmount to Number
      Add clip
      Add conversions between Number, XRPAmount and int64_t
      AMM Add Number class and associated algorithms
    ximinez committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    003312a View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2023

  1. Merge remote-tracking branch 'upstream/develop' into action-annoyances

    * upstream/develop:
      Update documented pathfinding configuration defaults: (XRPLF#4409)
    ximinez committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    da93312 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2023

  1. Merge remote-tracking branch 'upstream/develop' into action-annoyances

    * upstream/develop:
      Rename to fixNonFungibleTokensV1_2 and some cosmetic changes (XRPLF#4419)
      Only account specified as destination can settle through brokerage: (XRPLF#4399)
      Prevent brokered sale of NFToken to owner: (XRPLF#4403)
      Fix 3 issues around NFToken offer acceptance (XRPLF#4380)
      Allow NFT to be burned when number of offers is greater than 500 (XRPLF#4346)
      Add fixUnburnableNFToken feature (XRPLF#4391)
      Change default vote on fixUniversalNumber from yes to no (XRPLF#4414)
    ximinez committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    a7c0249 View commit details
    Browse the repository at this point in the history