fix: updateUserAttributeSetting during add/update/push flows #10773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging ba8ff68 into c70cc1f - view on LGTM.com new alerts:
|
5 tasks
akshbhu
force-pushed
the
updateUserAttributes
branch
from
ba8ff68
to
12e3785
Compare
|
This pull request introduces 1 alert when merging 12e3785 into c36fa71 - view on LGTM.com new alerts:
|
kevinold
added a commit
to kevinold/amplify-docs
that referenced
this pull request
Jul 22, 2022
kevinold
added a commit
to kevinold/amplify-docs
that referenced
this pull request
Jul 22, 2022
|
@akshbhu this needs a rebase |
akshbhu
force-pushed
the
updateUserAttributes
branch
9 times, most recently
from
54a8228
to
060590b
Compare
jhockett
reviewed
Aug 4, 2022
...y-auth/src/provider-utils/awscloudformation/auth-stack-builder/auth-cognito-stack-builder.ts
Outdated
Show resolved
Hide resolved
| @@ -1,11 +1,12 @@ | |||
| /* eslint-disable*/ | |||
There was a problem hiding this comment.
I'd prefer not adding a general eslint disable comment - if the linter is suggesting too many changes, then commit with --no-verify or scope the disable rule down
...rc/provider-utils/awscloudformation/auth-stack-builder/auth-user-pool-group-stack-builder.ts
Outdated
Show resolved
Hide resolved
| @@ -90,4 +90,4 @@ | |||
| "node" | |||
| ] | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Do you have a VSCode setting that is removing newlines at the end of JSON files? Ideally all text files should end in a newline
edwardfoyle
previously approved these changes
Aug 4, 2022
...ategory-auth/src/provider-utils/awscloudformation/auth-stack-builder/auth-stack-transform.ts
Outdated
Show resolved
Hide resolved
jhockett
reviewed
Aug 4, 2022
...y-auth/src/provider-utils/awscloudformation/auth-stack-builder/auth-cognito-stack-builder.ts
Outdated
Show resolved
Hide resolved
akshbhu
force-pushed
the
updateUserAttributes
branch
from
060590b
to
4f8f830
Compare
akshbhu
force-pushed
the
updateUserAttributes
branch
from
fcaf485
to
0ba4d4d
Compare
akshbhu
force-pushed
the
updateUserAttributes
branch
from
f884422
to
6fb4e36
Compare
danielleadams
approved these changes
Sep 13, 2022
edwardfoyle
approved these changes
Sep 13, 2022
2 tasks
katiegoines
pushed a commit
to aws-amplify/docs
that referenced
this pull request
Oct 20, 2022
…s with example (#4476) * fix: add section to clarify steps to update Cognito user email address with example Related to: aws-amplify/amplify-js#987 aws-amplify/amplify-cli#10773 * remove extra space
rachelnabors
pushed a commit
to aws-amplify/docs
that referenced
this pull request
Oct 21, 2022
…s with example (#4476) * fix: add section to clarify steps to update Cognito user email address with example Related to: aws-amplify/amplify-js#987 aws-amplify/amplify-cli#10773 * remove extra space
rachelnabors
added a commit
to aws-amplify/docs
that referenced
this pull request
Oct 21, 2022
* removes ionic * scours away ionic files * Remove typo * reverting yarn upgrade. we need to update the yarn lock * Fixed type for Auth.federatedSignIn() in lib/auth/js/social (#4699) * Fix lib-v1 error where refresh on root gave 404 (#4722) Co-authored-by: Thomas Leing <[email protected]> * fix: edits to next.js getting started to bring it current (#4672) * fix: edits to next.js getting started to bring it current * updates to next.js hosting content * Removing Responsive Components from directory * Updating responsive documentation * improved docs for responsive components * Updating responsive documentation * merging * Adding link to theme * minor fix * another minor fix * Update src/pages/console/uibuilder/responsive.mdx Co-authored-by: Rene Brandel <[email protected]> * Update src/pages/console/uibuilder/responsive.mdx Co-authored-by: Rene Brandel <[email protected]> * Update src/pages/console/uibuilder/responsive.mdx Co-authored-by: Rene Brandel <[email protected]> * Update src/pages/console/uibuilder/responsive.mdx Co-authored-by: Rene Brandel <[email protected]> * Update src/pages/console/uibuilder/responsive.mdx Co-authored-by: Rene Brandel <[email protected]> * Update src/pages/console/uibuilder/responsive.mdx Co-authored-by: Rene Brandel <[email protected]> * Update src/pages/console/uibuilder/responsive.mdx Co-authored-by: Rene Brandel <[email protected]> * Update src/pages/console/uibuilder/responsive.mdx Co-authored-by: Rene Brandel <[email protected]> * Update cspell.json * requested edits to documentation * Update cspell.json * Add Android dev-preview files back (#4727) Co-authored-by: Thomas Leing <[email protected]> * Update versions.ts * fix: ignore queries while switching platform (#4730) * fix: ignore queries while switching platform * fix: nextjs build failed with global object 'window' * Getting Started Tutorial : React update (#4676) * clarifying this needs a new terminal * updates * Update src/fragments/start/getting-started/common/prereq.mdx Co-authored-by: siegerts <[email protected]> * Update src/fragments/start/getting-started/react/api.mdx Co-authored-by: siegerts <[email protected]> * updating per review Co-authored-by: siegerts <[email protected]> * Facebook OAuth steps update (#4731) * Fixed type for Auth.federatedSignIn() in lib/auth/js/social * Fix facebook oauth setup steps * fix: add section to clarify steps to update Cognito user email address with example (#4476) * fix: add section to clarify steps to update Cognito user email address with example Related to: aws-amplify/amplify-js#987 aws-amplify/amplify-cli#10773 * remove extra space * React native getting started guide updates (#4714) * small updates to getting started guide * clarified the inspector panel location * Expo CLI wording update * remove react-native-picker and react-native package * update to RN getting started guide * updated installation of React Native CLI * update setup steps * removed broken closing tags * fixed tag * removed open tag without closing tag * added closing tag * removes ionic * omg merge conflict merginng. Much shame. Very sad. Co-authored-by: Tim Nguyen <[email protected]> Co-authored-by: Dan Kiuna <[email protected]> Co-authored-by: Thomas Leing <[email protected]> Co-authored-by: Thomas Leing <[email protected]> Co-authored-by: Kevin Old <[email protected]> Co-authored-by: wpeck-amplify <[email protected]> Co-authored-by: wrpeck <[email protected]> Co-authored-by: Rene Brandel <[email protected]> Co-authored-by: dengdan154 <[email protected]> Co-authored-by: Di Wu <[email protected]> Co-authored-by: siegerts <[email protected]> Co-authored-by: Abdallah Shaban <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue #10561
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.