removes ionic #4677
Merged
removes ionic #4677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salihgueler
previously approved these changes
Oct 10, 2022
timngyn
previously approved these changes
Oct 12, 2022
rachelnabors
dismissed stale reviews from timngyn, salihgueler, and abdallahshaban557
via
961ebb7
jacoblogan
previously approved these changes
Oct 20, 2022
katiegoines
reviewed
Oct 20, 2022
There was a problem hiding this comment.
@rachelnabors, just wanted to note a merge conflict in src/fragments/start/getting-started/ionic/setup.mdx
Co-authored-by: Thomas Leing <[email protected]>
* fix: edits to next.js getting started to bring it current * updates to next.js hosting content
Co-authored-by: Rene Brandel <[email protected]>
Co-authored-by: Rene Brandel <[email protected]>
Co-authored-by: Rene Brandel <[email protected]>
Co-authored-by: Rene Brandel <[email protected]>
Co-authored-by: Rene Brandel <[email protected]>
Co-authored-by: Rene Brandel <[email protected]>
Co-authored-by: Rene Brandel <[email protected]>
Co-authored-by: Rene Brandel <[email protected]>
Co-authored-by: Thomas Leing <[email protected]>
* fix: ignore queries while switching platform * fix: nextjs build failed with global object 'window'
* clarifying this needs a new terminal * updates * Update src/fragments/start/getting-started/common/prereq.mdx Co-authored-by: siegerts <[email protected]> * Update src/fragments/start/getting-started/react/api.mdx Co-authored-by: siegerts <[email protected]> * updating per review Co-authored-by: siegerts <[email protected]>
* Fixed type for Auth.federatedSignIn() in lib/auth/js/social * Fix facebook oauth setup steps
…s with example (#4476) * fix: add section to clarify steps to update Cognito user email address with example Related to: aws-amplify/amplify-js#987 aws-amplify/amplify-cli#10773 * remove extra space
* small updates to getting started guide * clarified the inspector panel location * Expo CLI wording update * remove react-native-picker and react-native package * update to RN getting started guide * updated installation of React Native CLI * update setup steps * removed broken closing tags * fixed tag * removed open tag without closing tag * added closing tag
|
@katiegoines Sorry, I'm trying my best to resolve the conflict, but it's not working out. Mind taking a look on your end? Edit: nevermind, I got it |
jacoblogan
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our Ionic content gets very little traffic, and we lack the deep expertise to keep them up to date regularly. Rather than risk greeting learners with out of date content, we'd like to retire the Ionic tutorial and refocus our efforts on the remaining platforms we've committed to.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.