Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting Started Tutorial : React update #4676

Merged
merged 6 commits into from
Oct 20, 2022
Merged

Conversation

rachelnabors
Copy link
Contributor

Updates the React getting started tutorial with some CLI dialog updates, styleguide conformity, and some explanation of how Amplify UI components work.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rachelnabors rachelnabors requested a review from a team as a code owner October 8, 2022 01:53
@siegerts siegerts requested a review from a team October 10, 2022 13:48
Copy link
Contributor

@abdallahshaban557 abdallahshaban557 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments here

src/fragments/start/getting-started/common/prereq.mdx Outdated Show resolved Hide resolved
Now that we have a running Ionic app, it's time to set up Amplify so that we can create the necessary backend services needed to support the app. From the root of the project, run:
Now that we have a running Ionic app, it's time to set up Amplify so that we can create the necessary backend services needed to support the app.

Open a new terminal. From the root of the project, run:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this section be removed so as not to conflict with the Ionic PR to remove this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Ionic should not be a part of this PR

src/fragments/start/getting-started/react/setup.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@abdallahshaban557 abdallahshaban557 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rachelnabors rachelnabors merged commit f62adda into main Oct 20, 2022
@rachelnabors rachelnabors deleted the gs-tut-javascript branch October 20, 2022 20:48
rachelnabors added a commit that referenced this pull request Oct 21, 2022
* clarifying this needs a new terminal

* updates

* Update src/fragments/start/getting-started/common/prereq.mdx

Co-authored-by: siegerts <[email protected]>

* Update src/fragments/start/getting-started/react/api.mdx

Co-authored-by: siegerts <[email protected]>

* updating per review

Co-authored-by: siegerts <[email protected]>
rachelnabors added a commit that referenced this pull request Oct 21, 2022
* removes ionic

* scours away ionic files

* Remove typo

* reverting yarn upgrade. we need to update the yarn lock

* Fixed type for Auth.federatedSignIn() in lib/auth/js/social (#4699)

* Fix lib-v1 error where refresh on root gave 404 (#4722)

Co-authored-by: Thomas Leing <[email protected]>

* fix: edits to next.js getting started to bring it current (#4672)

* fix: edits to next.js getting started to bring it current

* updates to next.js hosting content

* Removing Responsive Components from directory

* Updating responsive documentation

* improved docs for responsive components

* Updating responsive documentation

* merging

* Adding link to theme

* minor fix

* another minor fix

* Update src/pages/console/uibuilder/responsive.mdx

Co-authored-by: Rene Brandel <[email protected]>

* Update src/pages/console/uibuilder/responsive.mdx

Co-authored-by: Rene Brandel <[email protected]>

* Update src/pages/console/uibuilder/responsive.mdx

Co-authored-by: Rene Brandel <[email protected]>

* Update src/pages/console/uibuilder/responsive.mdx

Co-authored-by: Rene Brandel <[email protected]>

* Update src/pages/console/uibuilder/responsive.mdx

Co-authored-by: Rene Brandel <[email protected]>

* Update src/pages/console/uibuilder/responsive.mdx

Co-authored-by: Rene Brandel <[email protected]>

* Update src/pages/console/uibuilder/responsive.mdx

Co-authored-by: Rene Brandel <[email protected]>

* Update src/pages/console/uibuilder/responsive.mdx

Co-authored-by: Rene Brandel <[email protected]>

* Update cspell.json

* requested edits to documentation

* Update cspell.json

* Add Android dev-preview files back (#4727)

Co-authored-by: Thomas Leing <[email protected]>

* Update versions.ts

* fix: ignore queries while switching platform (#4730)

* fix: ignore queries while switching platform

* fix: nextjs build failed with global object 'window'

* Getting Started Tutorial : React update (#4676)

* clarifying this needs a new terminal

* updates

* Update src/fragments/start/getting-started/common/prereq.mdx

Co-authored-by: siegerts <[email protected]>

* Update src/fragments/start/getting-started/react/api.mdx

Co-authored-by: siegerts <[email protected]>

* updating per review

Co-authored-by: siegerts <[email protected]>

* Facebook OAuth steps update (#4731)

* Fixed type for Auth.federatedSignIn() in lib/auth/js/social

* Fix facebook oauth setup steps

* fix: add section to clarify steps to update Cognito user email address with example (#4476)

* fix: add section to clarify steps to update Cognito user email address with example

Related to:
aws-amplify/amplify-js#987
aws-amplify/amplify-cli#10773

* remove extra space

* React native getting started guide updates (#4714)

* small updates to getting started guide

* clarified the inspector panel location

* Expo CLI wording update

* remove react-native-picker and react-native package

* update to RN getting started guide

* updated installation of React Native CLI

* update setup steps

* removed broken closing tags

* fixed tag

* removed open tag without closing tag

* added closing tag

* removes ionic

* omg merge conflict merginng. Much shame. Very sad.

Co-authored-by: Tim Nguyen <[email protected]>
Co-authored-by: Dan Kiuna <[email protected]>
Co-authored-by: Thomas Leing <[email protected]>
Co-authored-by: Thomas Leing <[email protected]>
Co-authored-by: Kevin Old <[email protected]>
Co-authored-by: wpeck-amplify <[email protected]>
Co-authored-by: wrpeck <[email protected]>
Co-authored-by: Rene Brandel <[email protected]>
Co-authored-by: dengdan154 <[email protected]>
Co-authored-by: Di Wu <[email protected]>
Co-authored-by: siegerts <[email protected]>
Co-authored-by: Abdallah Shaban <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants