Skip to content

Commit

Permalink
danger: help users to write server tests (#1970)
Browse files Browse the repository at this point in the history
* danger: help users to write server tests

- fixes #1968
- adds the desired notice

* add trailing comma

https://circleci.com/gh/badges/shields/11866?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
  • Loading branch information
niccokunzmann authored and platan committed Aug 25, 2018
1 parent ddb3bf4 commit 9428c20
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion dangerfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,9 @@ if (packageJson.modified && !packageLock.modified) {
if (server.modified && !serviceTests.createdOrModified) {
warn([
'This PR modified the server but none of the service tests. ',
"That's okay so long as it's refactoring existing code.",
"That's okay so long as it's refactoring existing code. ",
"Otherwise, please consider adding tests to the service: ",
"https:/badges/shields/blob/master/doc/service-tests.md#readme",
].join(''));
}

Expand Down

0 comments on commit 9428c20

Please sign in to comment.