Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull request message about tests should mention the documentation #1968

Closed
niccokunzmann opened this issue Aug 23, 2018 · 1 comment · Fixed by #1970
Closed

Pull request message about tests should mention the documentation #1968

niccokunzmann opened this issue Aug 23, 2018 · 1 comment · Fixed by #1970
Labels
developer-experience Dev tooling, test framework, and CI

Comments

@niccokunzmann
Copy link
Contributor

niccokunzmann commented Aug 23, 2018 •
edited
Loading

In PR #1965, I can see the message

This PR modified the server but none of the service tests. That's okay so long as it's refactoring existing code.

I would like to add this to make more clear how to proceed.

Otherwise, please consider adding tests to the service: https:/badges/shields/blob/master/doc/service-tests.md#readme.
@PyvesB PyvesB added the developer-experience Dev tooling, test framework, and CI label Aug 23, 2018
@PyvesB
Copy link
Member

PyvesB commented Aug 23, 2018

Seem like a sensible thing to add in my opinion!

niccokunzmann added a commit to niccokunzmann/shields that referenced this issue Aug 23, 2018
@niccokunzmann
danger: help users to write server tests
6b7cdbd 
- fixes badges#1968
- adds the desired notice
@niccokunzmann niccokunzmann mentioned this issue Aug 23, 2018
Merged
niccokunzmann added a commit to niccokunzmann/shields that referenced this issue Aug 23, 2018
@niccokunzmann
danger: help users to write server tests
afc1eb0 
- fixes badges#1968
- adds the desired notice
platan pushed a commit that referenced this issue Aug 25, 2018
@niccokunzmann @platan
danger: help users to write server tests (#1970)
9428c20 
* danger: help users to write server tests

- fixes #1968
- adds the desired notice

* add trailing comma

https://circleci.com/gh/badges/shields/11866?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
developer-experience Dev tooling, test framework, and CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

danger: help users to write server tests niccokunzmann/shields
2 participants
@niccokunzmann @PyvesB