danger: help users to write server tests #1970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
niccokunzmann
commented
Aug 23, 2018
niccokunzmann
commented
- fixes Pull request message about tests should mention the documentation #1968
- adds the desired notice
Generated by 🚫 dangerJS |
PyvesB
reviewed
Aug 23, 2018
PyvesB
approved these changes
Aug 24, 2018
platan
reviewed
Aug 24, 2018
| "That's okay so long as it's refactoring existing code.", | ||
| "That's okay so long as it's refactoring existing code. ", | ||
| "Otherwise, please consider adding tests to the service: ", | ||
| "https:/badges/shields/blob/master/doc/service-tests.md#readme", |
There was a problem hiding this comment.
Do we need #readme at the of the url?
There was a problem hiding this comment.
It skips directly to the document you like to read. The other documentation files are not interesting. I added it for ease of use. Why would you remove it?
There was a problem hiding this comment.
Personally I think it's fine either way. 👍
There was a problem hiding this comment.
@niccokunzmann Thanks for explanation. I didn't notice the difference earlier. I agree with you, it's useful.
platan
approved these changes
Aug 25, 2018
|
@niccokunzmann thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.