Ensure data provider parameters are consistent with test methods signatures #2623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atures This addresses a deprecation notice that was introduced in PHPUnit 10.5.18
alcaeus
reviewed
Apr 19, 2024
tests/Doctrine/ODM/MongoDB/Tests/Functional/DocumentPersisterTest.php
Outdated
Show resolved
Hide resolved
IonBazan
approved these changes
Apr 19, 2024
jmikola
force-pushed
the
2.8-phpunit-deprecations
branch
from
bcf1d77
to
5ff41ec
Compare
jmikola
force-pushed
the
2.8-phpunit-deprecations
branch
from
5ff41ec
to
d8baea8
Compare
malarzm
approved these changes
Apr 21, 2024
|
Should this target 2.7.x? We're running phpunit ^10.4 there as well |
This was referenced Apr 22, 2024
|
Opened #2627 to target 2.7.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This addresses a deprecation notice that was introduced in PHPUnit 10.5.18 (sebastianbergmann/phpunit#5812)