[Reporting/Screenshots] add error for no shared items found on the page #52022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
added
(Deprecated) Feature:Reporting
tsullivan
requested review from
joelgriffith,
majagrubic,
ppisljar and
a team
This comment has been minimized.
This comment has been minimized.
tsullivan
force-pushed
the
reporting/fix-container-failure-messaging
branch
from
8d7fa97
to
0951fde
Compare
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
|
Ready for re-review |
tsullivan
commented
Dec 5, 2019
| @@ -313,7 +313,7 @@ export class VisualizeEmbeddable extends Embeddable<VisualizeInput, VisualizeOut | |||
|
|
|||
| div.setAttribute('data-test-subj', 'visualizationLoader'); | |||
| div.setAttribute('data-shared-item', ''); | |||
| div.setAttribute('data-shared-item-container', ''); | |||
| div.setAttribute('data-shared-items-container', ''); | |||
There was a problem hiding this comment.
Whoops, this is affecting Dashboard reports now, and causing them to break.
💔 Build Failed |
tsullivan
force-pushed
the
reporting/fix-container-failure-messaging
branch
from
0951fde
to
149022b
Compare
tsullivan
force-pushed
the
reporting/fix-container-failure-messaging
branch
from
149022b
to
0f474f9
Compare
|
@elasticmachine merge upstream |
joelgriffith
approved these changes
Dec 11, 2019
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Dec 12, 2019
…ge (elastic#52022) * [Reporting/Screenshots] add error for no shared items container found on the page * wording adjustment
timductive
pushed a commit
to timductive/kibana
that referenced
this pull request
Dec 16, 2019
…ge (elastic#52022) * [Reporting/Screenshots] add error for no shared items container found on the page * wording adjustment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR helps the triaging of #51309 as an issue. If there is a problem with the Kibana page where the Reporting integration will not work, Reporting will log an appropriate error.
This PR follows on #52109
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibilityFunctional tests to isolate the screen capture workflow is dependent on a draft PR: #48588