Sync badge #55113
Merged
Sync badge #55113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brittanyjoiner15
force-pushed
the
syncBadge
branch
from
2d1e0dc
to
c970670
Compare
brittanyjoiner15
force-pushed
the
syncBadge
branch
from
c970670
to
028a3b3
Compare
brittanyjoiner15
force-pushed
the
syncBadge
branch
from
028a3b3
to
52d3467
Compare
ogupte
reviewed
Jan 27, 2020
| @@ -231,6 +232,7 @@ export function WaterfallItem({ | |||
| </ErrorOverviewLink> | |||
| ) : null} | |||
| <Duration item={item} /> | |||
| {item.docType === 'span' && <SyncBadge sync={item.doc.span.sync} />} | |||
There was a problem hiding this comment.
since the undefined case is handled in the component, could replace this line with:
<SyncBadge sync={item.doc?.span?.sync} />
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 31, 2020
* master: (53 commits) Fix setting filters without $store value (elastic#56304) kuery_autocomplete -> convert remaining items to TS/Jest (elastic#56316) [Reporting] New Platform: moves most of our libs/constants and utils to np shims (elastic#55935) [reporting] remove a legacy cross-plugin import (elastic#56354) [DOCS] Updates example in Timelion doc (elastic#56444) [APM] Service map center button (elastic#56434) [skip-ci] Add example for migrating pre-handlers (elastic#56080) [ML] Fix Data Visualizer responsive layout (elastic#56372) Add missing docker settings (elastic#56411) [Endpoint] Add Endpoint Details route (elastic#55746) chore(NA): delete data/optimize with kbn clean (elastic#55890) System index templates can't be edited (elastic#55229) Sync badge (elastic#55113) Only fire appState changes when there is a change (elastic#56183) Import appropriate files to setup plugin system at the correct time (elastic#55956) [Monitoring] Change all configs to `monitoring.*` (elastic#56215) [ML] conditional rison encoding for query params (elastic#56380) Move tsvb server to new platform (elastic#55310) exclude tutorial resources from code ownership (elastic#55987) [Watcher] Follow up on flaky functional test (elastic#56384) ...
brittanyjoiner15
added a commit
to brittanyjoiner15/kibana
that referenced
this pull request
Jan 31, 2020
* adding span sync badge on waterfall and flyout
smith
pushed a commit
to smith/kibana
that referenced
this pull request
Feb 6, 2020
* adding span sync badge on waterfall and flyout
smith
added a commit
that referenced
this pull request
Feb 7, 2020
* adding span sync badge on waterfall and flyout Co-authored-by: Brittany Joiner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Span Sync badge to transactions waterfall and flyout.
Fixes #25928