Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move tsvb server to new platform #55310

Merged
merged 16 commits into from
Jan 30, 2020
Merged

Move tsvb server to new platform #55310

merged 16 commits into from
Jan 30, 2020

Conversation

flash1293
Copy link
Contributor

@flash1293 flash1293 commented Jan 20, 2020 •
edited
Loading

This PR moves the TSVB server to the new platform. Not all files are changed for this migration, instead a facade was used to emulate the behavior of the legacy request object. In a separate PR this will be addressed by converting all files to typescript and passing down well formed context objects.

@flash1293 flash1293 added Feature:TSVB TSVB (Time Series Visual Builder) v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:NP Migration v7.7.0 labels Jan 20, 2020
@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@flash1293 flash1293 marked this pull request as ready for review January 22, 2020 12:56
@flash1293 flash1293 added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Jan 22, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kertal
Copy link
Member

kertal commented Jan 24, 2020

@elasticmachine merge upstream

@kertal
Copy link
Member

kertal commented Jan 27, 2020

@elasticmachine merge upstream

kertal
kertal approved these changes Jan 27, 2020
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 👍 , tested locally in Chrome.

alexwizp
alexwizp requested changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@alexwizp alexwizp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, search by normal index works fine, but search by Rollup Index is broken =(

@flash1293 flash1293 requested a review from a team as a code owner January 29, 2020 10:21
@afgomez afgomez self-requested a review January 29, 2020 11:59
afgomez
afgomez suggested changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@afgomez afgomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. The host page in the metrics app is not working anymore :(

@flash1293
Copy link
Contributor Author

@afgomez Sorry, pushed too early, forgot to pass a parameter through. Could you check again?

afgomez
afgomez approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@afgomez afgomez left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flash1293 pulled the changes. It seems to work again 🎉

@flash1293
Copy link
Contributor Author

@alexwizp Could you check again? Rollups should work as well again.

@flash1293
Copy link
Contributor Author

@alisonelizabeth I had to modify the rollup server side code in a few places, could you take a look?

alisonelizabeth
alisonelizabeth approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rollup code changes LGTM.

@joshdover joshdover mentioned this pull request Jan 29, 2020
Closed
46 tasks
@flash1293 flash1293 mentioned this pull request Jan 30, 2020
Closed
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alexwizp alexwizp self-requested a review January 30, 2020 14:22
alexwizp
alexwizp approved these changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@alexwizp alexwizp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested locally, Rollup search works fine

@flash1293 flash1293 merged commit 74b9ed6 into elastic:master Jan 30, 2020
@flash1293 flash1293 deleted the migrate-tsvb-api branch January 30, 2020 15:43
@flash1293 flash1293 mentioned this pull request Jan 30, 2020
Merged
flash1293 added a commit to flash1293/kibana that referenced this pull request Jan 30, 2020
@flash1293
Move tsvb server to new platform (elastic#55310)
3b5838f
flash1293 added a commit that referenced this pull request Jan 30, 2020
@flash1293
Move tsvb server to new platform (#55310) (#56394)
0a32447
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 31, 2020
@gmmorris
Merge branch 'master' into alerting/details-ui
467bbc4 
* master: (53 commits)
  Fix setting filters without $store value (elastic#56304)
  kuery_autocomplete -> convert remaining items to TS/Jest (elastic#56316)
  [Reporting] New Platform: moves most of our libs/constants and utils to np shims (elastic#55935)
  [reporting] remove a legacy cross-plugin import (elastic#56354)
  [DOCS] Updates example in Timelion doc (elastic#56444)
  [APM] Service map center button (elastic#56434)
  [skip-ci] Add example for migrating pre-handlers (elastic#56080)
  [ML] Fix Data Visualizer responsive layout  (elastic#56372)
  Add missing docker settings (elastic#56411)
  [Endpoint] Add Endpoint Details route (elastic#55746)
  chore(NA): delete data/optimize with kbn clean (elastic#55890)
  System index templates can't be edited (elastic#55229)
  Sync badge (elastic#55113)
  Only fire appState changes when there is a change (elastic#56183)
  Import appropriate files to setup plugin system at the correct time (elastic#55956)
  [Monitoring] Change all configs to `monitoring.*` (elastic#56215)
  [ML] conditional rison encoding for query params (elastic#56380)
  Move tsvb server to new platform (elastic#55310)
  exclude tutorial resources from code ownership (elastic#55987)
  [Watcher] Follow up on flaky functional test (elastic#56384)
  ...
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jan 31, 2020
@jloleysens
Merge branch '7.x' of github.com:elastic/kibana into backport/7.x/pr-…
f8afb1b 
…56356

* '7.x' of github.com:elastic/kibana: (23 commits)
  Fix setting filters without $store value (elastic#56304) (elastic#56475)
  [ML] Fix Data Visualizer responsive layout  (elastic#56372) (elastic#56472)
  [ML] conditional rison encoding for query params (elastic#56380) (elastic#56469)
  kuery_autocomplete -> convert remaining items to TS/Jest (elastic#56316) (elastic#56471)
  [APM] Fit service map to container (elastic#56336) (elastic#56463)
  Add animation to service map layout (elastic#56042) (elastic#56460)
  chore(NA): delete data/optimize with kbn clean (elastic#55890) (elastic#56422)
  [APM] Storybook support (elastic#54970) (elastic#56445)
  [DOCS] Updates example in Timelion doc (elastic#56444) (elastic#56454)
  [Logs UI] Fix Check for New Data button on empty indices screen (elastic#56239) (elastic#56320)
  [DOCS] Adds breaking changes for 7.6 (elastic#56437)
  [Monitoring] Change all configs to `monitoring.*` (elastic#56215) (elastic#56421)
  [skip-ci] Add example for migrating pre-handlers (elastic#56080) (elastic#56436)
  [7.x] System index templates can't be edited (elastic#55229) (elastic#56417)
  Add missing docker settings (elastic#56411)
  [Uptime] Use dynamic index pattern in Uptime (elastic#55446) (elastic#56386)
  fix edit rule for detections (elastic#56333) (elastic#56405)
  [Filter Bar] Remove flickering when opening filter bar popover (elastic#56222) (elastic#56385)
  [ILM] Index Lifecycle Policies show wrong unit in Kibana UI (elastic#55228) (elastic#55757)
  Move tsvb server to new platform (elastic#55310) (elastic#56394)
  ...
@alexwizp alexwizp mentioned this pull request Nov 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afgomez afgomez afgomez approved these changes

@kertal kertal kertal approved these changes

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

@alexwizp alexwizp alexwizp approved these changes

Assignees
No one assigned
Labels
Feature:NP Migration Feature:TSVB TSVB (Time Series Visual Builder) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@flash1293 @elasticmachine @kertal @kibanamachine @afgomez @alisonelizabeth @alexwizp