[Reporting] New Platform: moves most of our libs/constants and utils to np shims #55935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelgriffith
added
release_note:skip
|
@joelgriffith is this a WIP or is it ready for review? |
|
Something may have broken when the master branch was merged, but I did a quick check and saw that export Discover as CSV is broken: |
|
@pgayvallet this was ready for review, but it might make better sense to wait until I get the rest moved over to shims. @tsullivan thanks for mentioning that, I couldn't even get master running late Friday, so you got further than I did. Will take a look here in a bit. |
pgayvallet
approved these changes
Jan 28, 2020
19 tasks
|
ping @elastic/kibana-canvas as code owners to review :) |
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 31, 2020
* master: (53 commits) Fix setting filters without $store value (elastic#56304) kuery_autocomplete -> convert remaining items to TS/Jest (elastic#56316) [Reporting] New Platform: moves most of our libs/constants and utils to np shims (elastic#55935) [reporting] remove a legacy cross-plugin import (elastic#56354) [DOCS] Updates example in Timelion doc (elastic#56444) [APM] Service map center button (elastic#56434) [skip-ci] Add example for migrating pre-handlers (elastic#56080) [ML] Fix Data Visualizer responsive layout (elastic#56372) Add missing docker settings (elastic#56411) [Endpoint] Add Endpoint Details route (elastic#55746) chore(NA): delete data/optimize with kbn clean (elastic#55890) System index templates can't be edited (elastic#55229) Sync badge (elastic#55113) Only fire appState changes when there is a change (elastic#56183) Import appropriate files to setup plugin system at the correct time (elastic#55956) [Monitoring] Change all configs to `monitoring.*` (elastic#56215) [ML] conditional rison encoding for query params (elastic#56380) Move tsvb server to new platform (elastic#55310) exclude tutorial resources from code ownership (elastic#55987) [Watcher] Follow up on flaky functional test (elastic#56384) ...
jfsiii
pushed a commit
to jfsiii/kibana
that referenced
this pull request
Feb 4, 2020
…to np shims (elastic#55935) * Moves a majority of our UI lib/component and utils to np shims * Fixing some slight np differences from legacy * Mostly shimmed client, save for a few APIs and routing * Fixing canvas job notifier * Un-needed typedef file Co-authored-by: Elastic Machine <[email protected]>
|
@joelgriffith is this PR planned to be backported? I have a small collision with backporting of mine (#57178). |
tsullivan
pushed a commit
to tsullivan/kibana
that referenced
this pull request
Feb 10, 2020
…to np shims (elastic#55935) * Moves a majority of our UI lib/component and utils to np shims * Fixing some slight np differences from legacy * Mostly shimmed client, save for a few APIs and routing * Fixing canvas job notifier * Un-needed typedef file Co-authored-by: Elastic Machine <[email protected]>
|
@maryia-lapata @flash1293 sorry about the oversight. I put up a backport PR just now: #57222 |
tsullivan
added a commit
that referenced
this pull request
Feb 11, 2020
…utils to np shims (#55935) (#57222) * [Reporting] New Platform: moves most of our libs/constants and utils to np shims (#55935) * Moves a majority of our UI lib/component and utils to np shims * Fixing some slight np differences from legacy * Mostly shimmed client, save for a few APIs and routing * Fixing canvas job notifier * Un-needed typedef file Co-authored-by: Elastic Machine <[email protected]> * fix bad merge Co-authored-by: Joel Griffith <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moves all of our utils, libs, and other libs over to np equivalents for shimming purposes. Moved a few modules to be simple functions (versus Classes the just export an instance), and did a few TS conversions.
Part of #53898