-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Canvas] Better handling navigating to/from canvas #66407
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crob611
added
review
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
loe:small
Small Level of Effort
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
impact:critical
This issue should be addressed immediately due to a critical level of impact on the product.
v7.8.0
v7.9.0
labels
May 13, 2020
Pinging @elastic/kibana-canvas (Team:Canvas) |
crob611
force-pushed
the
canvas-app-navigation
branch
from
May 13, 2020 20:30
1863790
to
dbcc254
Compare
@elasticmachine merge upstream |
poffdeluxe
approved these changes
May 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
jloleysens
added a commit
that referenced
this pull request
May 26, 2020
…ine-editor * 'master' of github.com:elastic/kibana: (129 commits) [Canvas] Force embeddables to refresh when renderable reevaluated (#67133) [Canvas] Better handling navigating to/from canvas (#66407) [Ingest pipelines] Fix schema validation for simulate and update routes (#67199) do not use es from setup (#67277) Auto expand replicas for event log (#67286) Observability & APM do not use elasticsearch client provided via setup contract (#67263) Fix privileges check when security is not enabled (#67308) add IIS home (#66918) [ML] Adding additional job service endpoint tests (#66892) [Ingest Manager] Update fleet internal doc with latest flags (#67193) [Discover] Deangularize the loading spinner (#67165) Add `application.navigateToUrl` core API (#67110) Improve indexpattern without timefield functional test (#67031) KibanaContext in index pattern managment ui (#66985) Fix Azure metrics tutorial inside the App Home/ Add data area (#66901) add azure logs home (#66910) fix: rum agent should work correctly on new platform (#67037) [test_utils/Testbed] Move to src/test_utils folder (OSS) (#66898) only block registration when appRoute contains the exact basePath (#67125) Changed actions API endpoints urls to follow Kibana STYLEGUIDE (#65936) ... # Conflicts: # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form_fields.tsx
crob611
pushed a commit
to crob611/kibana
that referenced
this pull request
May 26, 2020
* Better handling navigating to/from canvas * fix types * prettier Co-authored-by: Elastic Machine <[email protected]>
crob611
pushed a commit
to crob611/kibana
that referenced
this pull request
May 26, 2020
* Better handling navigating to/from canvas * fix types * prettier Co-authored-by: Elastic Machine <[email protected]>
crob611
pushed a commit
that referenced
this pull request
May 26, 2020
* Better handling navigating to/from canvas * fix types * prettier Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
crob611
pushed a commit
that referenced
this pull request
May 26, 2020
* Better handling navigating to/from canvas * fix types * prettier Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
impact:critical
This issue should be addressed immediately due to a critical level of impact on the product.
loe:small
Small Level of Effort
release_note:skip
Skip the PR/issue when compiling release notes
review
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
v7.8.0
v7.9.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #66183
We were tearing down all of Canvas (services, stores, navigation, etc) when navigating away from Canvas.
But there were a couple of scenarios where we could have requests in flight that upon completion are still dependent on those things. (Refreshing a workpad. Auto refresh timers. Autoplay timers.)
So this PR leaves some area uncleaned and then reinitializes them new upon rentering Canvas.
We are still tearing down our router and history (maybe we don't need to, but we can revisit that). But our router is dependent on being manipulated by some middleware at startup, so we are rebuilding the store when re-entering Canvas.
Would be good to come back and entirely clean up our routing/history stuff and attempt to make it much less dependent on the store.